Implied photo #100
Merged
Implied photo #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aaronpk @dissolve @barnabywalters and anyone else: if you have time would you mind reviewing this PR? I'd like to get this set of three PRs merged so I can work on further improvements. This is the third of the three. |
|
This one looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added failing tests and fix for #88.
This adds support for parsing the photo from
object[data]and also corrects the parsing for nested elements. Previously it wouldn't parse if the nested element had siblings (which may have been correct at the time); now it checks for:only-of-typeamong the siblings. I commented out the two tests that I believe were incorrect and re-wrote them.Initially I wrote this as part of the
try...catchcode that existed already. I found I was repeating basically the same code for each parse attempt, so figured I would make it a separate method that loops through the xpaths. I hope that's not too bold of me. I can put it back in thetry...catchif desired.