Parse an image for src and alt #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gRegorLove
requested changes
Apr 6, 2020
|
Looking good, just a couple more tests to be updated to pass: |
pfefferle
reviewed
Apr 23, 2020
| @@ -536,6 +552,10 @@ public function language(DOMElement $el) | |||
|
|
|||
| // TODO: figure out if this has problems with sms: and geo: URLs | |||
| public function resolveUrl($url) { | |||
| // If not a string then return. | |||
| if (!is_string($url)){ | |||
pfefferle
reviewed
Apr 23, 2020
| @@ -634,7 +654,9 @@ public function parseP(\DOMElement $p) { | |||
| public function parseU(\DOMElement $u) { | |||
| if (($u->tagName == 'a' or $u->tagName == 'area' or $u->tagName == 'link') and $u->hasAttribute('href')) { | |||
| $uValue = $u->getAttribute('href'); | |||
| } elseif (in_array($u->tagName, array('img', 'audio', 'video', 'source')) and $u->hasAttribute('src')) { | |||
| } elseif ( $u->tagName == 'img' and $u->hasAttribute('src') ) { | |||
There was a problem hiding this comment.
the whitespaces before/after the braces is WP coding style ;)
|
Pinging @gRegorLove as your previous comments re testing should all be addressed now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR I've tried for this project. Having a little trouble with the testing.