Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add failing test and fix for #91 #92

Merged
merged 2 commits into from
Apr 17, 2016
Merged

add failing test and fix for #91 #92

merged 2 commits into from
Apr 17, 2016

Conversation

aaronpk
Copy link
Member

@aaronpk aaronpk commented Apr 14, 2016

only looks on a,link, and area for rel attributes, since these are the only elements that HTML allows to have the rel attribute.

only looks on `a`,`link`, and `area` for rel attributes, since these are the only elements that HTML allows to have the rel attribute.
@kevinmarks
Copy link
Member

From IRC:
@aaronpk BOT [2:39 PM]
I only have tiny internet right now so can't comment on my PR, so can someone add this as a comment? Don't merge my php-mf2 PR yet because I just realized it's wrong and I'm going to add another test case to webmention.rocks tomorrow, and I have a plan to fix the PR

@aaronpk
Copy link
Member Author

aaronpk commented Apr 15, 2016

It appears XPath does not have the problem @tantek and I suspected after all. We were assuming that since the query used an "or" expression at the top level, which XPath treats as a "union", that it would return the tags in the order they were in the query. However I've added tests and it looks like XPath is still returning the tags in document order. This is fine to merge now!

@barnabywalters barnabywalters merged commit f8480ec into microformats:master Apr 17, 2016
@barnabywalters
Copy link
Collaborator

Had brief discussion at IWC Nürnberg with @tantek @aaronpk about whether to future proofing or HTML spec compliance is higher priority, decided that HTML spec compliance takes priority. Thanks for your work on this @aaronpk!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants