a few more tests incorrect #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 4, 2017 08:27
as per http://microformats.org/wiki/microformats2-parsing#parse_an_element_for_class_microformats if inside a non-backcompat root (in this case h-card) do not parse adr as p-adr h-adr(backcompat) but rather as just h-adr(backcompat)
h-review-aggregate follows rules for h-review and per http://microformats.org/wiki/h-review#Backward_Compatibility you only parse as h-item if it is not also vevent, vcard, or vproduct
as per http://microformats.org/wiki/h-product#Backward_Compatibility description in backcompat mode should be parsed as p- not e-
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
description of issues and links are in the individual commit messages