MCS: fallback to port 443 if 5228 is blocked #1662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was not able to validate it but probably good for review. |
It will, but you could replace the APK installed on the system with your own. You can also try the emulator, https://github.com/microg/GmsCore/wiki/Development-Tools#using-the-emulator
No, since that only spoofs the reported signature, and doesn't touch the actual app upgrade signature checking code. |
|
Thank you for your reply!
Good idea. I tried this on Android 11 with Magisk: I had to create a Magisk module to replace Is it the wrong APK?
Yes I guess I could, I don't know well that.
ACK! |
According to Google Firebase's doc, other ports than 5228 can be used:
If your organization has a firewall to restrict traffic to or from
the Internet, you need to configure it to allow mobile devices to
connect with FCM in order for devices on your network to receive
messages. FCM typically uses port 5228, but it sometimes uses 443,
5229, and 5230.
Src: https://firebase.google.com/docs/cloud-messaging/concept-options#messaging-ports-and-your-firewall
As suggested by @mar-v-in, it is enough to first try 5228 and then only
try with 443 as fall back port. Indeed, it would be surprising to find
any firewall blocking port 5228 but not 5229.
If none of these ports, a new attempt will be done later as before.
Closes: microg#408
Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
matttbe
force-pushed
the
gcm-mcs-port-fallback
branch
from
0bd1bc2 to
423db81
Compare
|
I finally managed to validate this: I had to remove the data in I found that in the previous version, I forgot to send the Here is what we can see when I block the port 5228 with And when I block the port 443 as well: (as you can see, I left the whole stacktrace in case of error to connect to the server) So it seems to do the job and this is ready for review. |
mar-v-in
approved these changes
Aug 1, 2022
|
Thanks. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Google Firebase's doc, other ports than 5228 can be used:
Src: https://firebase.google.com/docs/cloud-messaging/concept-options#messaging-ports-and-your-firewall
As suggested by @mar-v-in, it is enough to first try 5228 and then only
try with 443 as fall back port. Indeed, it would be surprising to find
any firewall blocking port 5228 but not 5229.
Closes: #408
Note: this PR was marked as "Draft" for the moment for 2 reasons:
The PR has now been tested and ready to be reviewed.