fix(audio): mp4 audio only files

microlinkhq · Dec 29, 2023 · c5b7a01 · c5b7a01
1 parent d1f8bce
commit c5b7a01
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/packages/metascraper-audio/src/index.js b/packages/metascraper-audio/src/index.js
@@ -29,6 +29,8 @@ const toAudioFromDom = toRule((domNodes, opts) => {
         .get(1)
         // https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/MIME_types/Common_types
         .replace('mpeg', 'mp3')
+        /* mp4 is commonly used for video */
+        .replace('mp4', 'mp3')
         .value()
     }))
     .uniqWith(isEqual)

diff --git a/packages/metascraper-audio/test/index.js b/packages/metascraper-audio/test/index.js
@@ -148,3 +148,18 @@ test('`audio > source:src` with content type and relative src', async t => {
     'https://www.theverge.com/2018/1/22/16921092/audio-small'
   )
 })
+
+test('`audio > source:src` with mp4 mime type', async t => {
+  const html = `
+    <audio controls>
+      <source type="audio/mp4" src="https://cdn.microlink.io/file-examples/sample-audio.mp4">
+    </audio>
+    `
+  const url = 'https://metascraper.js.org'
+  const metascraper = createMetascraper()
+  const metadata = await metascraper({ html, url })
+  t.is(
+    metadata.audio,
+    'https://cdn.microlink.io/file-examples/sample-audio.mp4'
+  )
+})