Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add micromark-util-types as a dependency #6

Merged
merged 2 commits into from
Feb 27, 2023
Merged

Conversation

arcanis
Copy link
Contributor

@arcanis arcanis commented Feb 15, 2023

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

Various type imports directly reference micromark-util-types:

* @typedef {import('micromark-util-types').Extension} Extension
* @typedef {import('micromark-util-types').ConstructRecord} ConstructRecord
* @typedef {import('micromark-util-types').Construct} Construct
* @typedef {import('micromark-util-types').Tokenizer} Tokenizer
* @typedef {import('micromark-util-types').State} State

Since it isn't listed in the dependencies, loose package managers like npm may generate incorrect hoisting (so TS would resolve the wrong version of micromark-util-types), and strict package managers like Yarn or pnpm may cause TS to fail to resolve the dependency.

This diff simply adds the missing dependency.

@github-actions github-actions bot added the 👋 phase/new Post is being triaged automatically label Feb 15, 2023
@github-actions

This comment has been minimized.

@github-actions github-actions bot added 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Feb 15, 2023
@arcanis
Copy link
Contributor Author

arcanis commented Feb 15, 2023

The typecheck errors look unrelated to the PR itself 🤔

@wooorm
Copy link
Member

wooorm commented Feb 15, 2023

This looks good, thanks! TS is indeed unrelated. I’ll get back to the repo in ±10 days as I’m on holiday. OK?

@wooorm wooorm changed the title Adds missing micromark-util-types dependency Add micromark-util-types as a dependency Feb 27, 2023
@wooorm wooorm merged commit 64ae64f into micromark:main Feb 27, 2023
@github-actions

This comment has been minimized.

@wooorm
Copy link
Member

wooorm commented Feb 27, 2023

Thanks, released in 1.0.1!

@wooorm wooorm added 📚 area/docs This affects documentation 💪 phase/solved Post is done labels Feb 27, 2023
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 area/docs This affects documentation 💪 phase/solved Post is done
Development

Successfully merging this pull request may close these issues.

3 participants