Merge pull request #129 from styfle/remove-process-global

feat!: remove process global to work outside of node
micromatch · Feb 8, 2024 · c0f9c55 · c0f9c55
2 parents 5214db4 + 3b2726c
commit c0f9c55
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 26 deletions.
diff --git a/lib/parse.js b/lib/parse.js
@@ -698,10 +698,6 @@ const parse = (input, options) => {
         const next = peek();
         let output = value;
 
-        if (next === '<' && !utils.supportsLookbehinds()) {
-          throw new Error('Node.js v10 or higher is required for regex lookbehinds');
-        }
-
         if ((prev.value === '(' && !/[!=<:]/.test(next)) || (next === '<' && !/<([!=]|\w+>)/.test(remaining()))) {
           output = `\\${value}`;
         }

diff --git a/lib/utils.js b/lib/utils.js
@@ -19,16 +19,6 @@ exports.removeBackslashes = str => {
   });
 };
 
-exports.supportsLookbehinds = () => {
-  if (typeof process !== 'undefined') {
-    const segs = process.version.slice(1).split('.').map(Number);
-    if (segs.length === 3 && segs[0] >= 9 || (segs[0] === 8 && segs[1] >= 10)) {
-      return true;
-    }
-  }
-  return false;
-};
-
 exports.escapeLast = (input, char, lastIdx) => {
   const idx = input.lastIndexOf(char, lastIdx);
   if (idx === -1) return input;

diff --git a/test/regex-features.js b/test/regex-features.js
@@ -18,18 +18,10 @@ describe('regex features', () => {
 
   describe('regex lookarounds', () => {
     it('should support regex lookbehinds', () => {
-      if (utils.supportsLookbehinds()) {
-        assert(isMatch('foo/cbaz', 'foo/*(?<!d)baz'));
-        assert(!isMatch('foo/cbaz', 'foo/*(?<!c)baz'));
-        assert(!isMatch('foo/cbaz', 'foo/*(?<=d)baz'));
-        assert(isMatch('foo/cbaz', 'foo/*(?<=c)baz'));
-      }
-    });
-
-    it('should throw an error when regex lookbehinds are used on an unsupported node version', () => {
-      Reflect.defineProperty(process, 'version', { value: 'v6.0.0' });
-      assert.throws(() => isMatch('foo/cbaz', 'foo/*(?<!c)baz'), /Node\.js v10 or higher/);
-      Reflect.defineProperty(process, 'version', { value: version });
+      assert(isMatch('foo/cbaz', 'foo/*(?<!d)baz'));
+      assert(!isMatch('foo/cbaz', 'foo/*(?<!c)baz'));
+      assert(!isMatch('foo/cbaz', 'foo/*(?<=d)baz'));
+      assert(isMatch('foo/cbaz', 'foo/*(?<=c)baz'));
     });
   });