Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add basic typescript typings #53

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

larshp
Copy link

@larshp larshp commented Dec 24, 2019

This PR adds basic typescript typings based on the existing jsdoc comments.

The types are not perfect as they are auto generated, but on the other hand it does not need to be maintained manually, and something is better than nothing. The automatic generation of types from Javascript was introduced in https://devblogs.microsoft.com/typescript/announcing-typescript-3-7/

  • Add configuration for Typescript compiler
  • 2 JSDoc comments fixed
  • package.json changed to include the types

#18

@larshp
Copy link
Author

larshp commented Feb 14, 2020

any thoughts?

@larshp
Copy link
Author

larshp commented Mar 4, 2020

@jonschlinkert ?

@larshp larshp mentioned this pull request Apr 4, 2020
@p-kuen
Copy link

p-kuen commented Apr 13, 2020

Would love to see this get merged.

@larshp
Copy link
Author

larshp commented Apr 13, 2020

Yeah, lets see, been a while...

@shellscape
Copy link

@jonschlinkert would this be better to live here or on DefinitelyTyped?

@p-kuen
Copy link

p-kuen commented Apr 28, 2020

I just added picomatch types to DefinitelyTyped. This can be closed.

@larshp
Copy link
Author

larshp commented Apr 28, 2020

from my point of view, it would be nicer to always have the types as part of the package, and always have it matching without additional manual effort

but thanks @Patcher56, I'll probably go ahead and use those types to convert my project to using picomatch

@p-kuen
Copy link

p-kuen commented Apr 28, 2020

Yeah, I am the same opinion. But as we didn't get an answer this is the only option to add types to picomatch.

The best solution in my opinion would be to convert picomatch to typescript. Then the types would be no problem at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants