Guard against saving empty config

micromdm · Jul 21, 2022 · c77808e · c77808e
1 parent 3edfc1f
commit c77808e
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/http/api/config.go b/http/api/config.go
@@ -3,6 +3,7 @@ package api
 import (
 	"context"
 	"encoding/json"
+	"errors"
 	"net/http"
 
 	"github.com/micromdm/nanodep/client"
@@ -67,6 +68,14 @@ func StoreConfigHandler(store ConfigStorer, logger log.Logger) http.HandlerFunc
 			return
 		}
 		defer r.Body.Close()
+		if config.BaseURL == "" {
+			err = errors.New("empty base URL")
+		}
+		if err != nil {
+			logger.Info("msg", "decoded config", "err", err)
+			jsonError(w, err)
+			return
+		}
 		err = store.StoreConfig(r.Context(), r.URL.Path, config)
 		if err != nil {
 			logger.Info("msg", "storing config", "err", err)