Consumer key change "force" mode #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3edfc1f introduced a change to try and protect from accidentally overwriting the incorrect DEP tokens by rejecting a mismatched consumer key for #1. However, it had a bug, reported in #10 whereby if no initial token existed, saving a new one would fail. Further, there are legitimate cases where a consumer key can change, so this is a workflow we need to support. To do that we introduce the "force" parameter in this PR that can be specified when saving tokens to bypass the matching consumer key check. See the modified docs for usage. We also fixed the initial loading situation reported in #10.
Resolves #1.
Resolves #7.
Resolves #10.