add KV transaction interfaces and new transaction wrapping key-value store #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Go interfaces for beginning, committing, and rolling back transactions on key-value stores.
The included KV stores (
kvmapandkvdiskv) do not support transactions. So we also add a KV store wrapper that supports in-memory staged-write non-atomic transactions with this PR. This allows us to wrap any existing KV store that may not support transactions to add some support. Unfortunately as it layers over non-transaction stores we can't actually guarantee atomicity for multiple staged write operations (that is: a transaction may end-up only being partially committed). Even so this allows us to get some of the benefit of transactions (largely discard/roll back support) but more importantly to use the same interfaces for real transaction-supporting KV stores that can plug into the interfaces.