Replace old pkcs7 library with mozilla's #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While investigating a pkcs7 issue, and chatting with @groob, it sounded like go.mozilla.org/pkcs7 was the place to be. This reverts the not-usable SCEPEncryptionAlgorithm stuff (micromdm#51) and swaps to mozilla's library. **Note:** This likely needs more tests. Especially with the addition of p7.Verify
groob
approved these changes
Nov 10, 2020
|
I'm merging this to HEAD first, and will take some time to fix any outstanding issues if they come up. The changes look good to me. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating a pkcs7 issue, and chatting with @groob, it sounded like go.mozilla.org/pkcs7 was the place to be.
This reverts the not-usable SCEPEncryptionAlgorithm stuff (#51) and swaps to mozilla's library.
Note: This likely needs more tests. Especially with the addition of p7.Verify