BoltDB Depot serial number changes for data races #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessepeterson
force-pushed
the
boltdb-serial-changes
branch
from
66f95ef
to
4f80856
Compare
…r req. also undo locking done in micromdm#185 in lieu of this fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes a few things to make serial number generation make a bit more sense. This brings the implementation in line with the following statements:
To that end adjust a bunch of things to make it conform to this. Add a mutex in case
Serial()is called multiple times concurrently. Fix a few other unrelated things along the way. See also #185 for more context.