Add -key-encipherment-selector and use CA certs for verification
#217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a SCEP server returns multiple certificates, it is possible that not all certificates can or should be used for encryption. There already was a `KeyEnciphermentsSelector`, but that wasn't readily usable with the provided SCEP client. A new flag was added to enable this selector: `-key-encipherment-selector`. It will filter out certificates that aren't marked as being usable for key or data encryption. When verifying the `PKIMessage` from the CA only the `Recipients` in the outgoing message were being looked through when selecting a certificate to verify the signature. This commit changes that by including all certificates returned by the CA when the client performs the `GetCACerts` operation.
jessepeterson
requested changes
Dec 1, 2023
There was a problem hiding this comment.
Hi @hslatman! Sorry for the mega delay here. In general we don't like globals, so would prefer to keep the flags inside of main. Would you mind putting those back and I can re-review? Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a SCEP server returns multiple certificates, it is possible that not all certificates can or should be used for encryption. There already was a
KeyEnciphermentsSelector, but that wasn't readily usable with the provided SCEP client. A new flag was added to enable this selector:-key-encipherment-selector. It will filter out certificates that aren't marked as being usable for key or data encryption.When verifying the
PKIMessagefrom the CA only theRecipientsin the outgoing message were being looked through when selecting a certificate to verify the signature. This commit changes that by including all certificates returned by the CA when the client performs theGetCACertsoperation.