Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document New Relic's own MeterRegistry #102

Merged
merged 2 commits into from
Dec 9, 2019
Merged

Document New Relic's own MeterRegistry #102

merged 2 commits into from
Dec 9, 2019

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Oct 14, 2019

This PR documents New Relic's own MeterRegistry.

See micrometer-metrics/micrometer#1588 (comment)

@izeye izeye mentioned this pull request Oct 14, 2019
Merged
shakuzen
shakuzen approved these changes Dec 9, 2019
View reviewed changes
Copy link
Member

@shakuzen shakuzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this. I just made a wording suggestion as I found it easier to parse the sentence that way.

src/docs/implementations/new-relic.adoc Outdated Show resolved Hide resolved
@izeye @shakuzen
Polish
94af8a6 
Co-Authored-By: Tommy Ludwig <8924140+shakuzen@users.noreply.github.com>
@shakuzen shakuzen merged commit fc40880 into micrometer-metrics:master Dec 9, 2019
@izeye izeye deleted the new-relic branch December 9, 2019 11:38
@shakuzen shakuzen mentioned this pull request Mar 13, 2020
Closed
@breedx-nr breedx-nr mentioned this pull request Jun 2, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shakuzen shakuzen shakuzen approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@izeye @shakuzen