New Relic Micrometer Spring Legacy Updates #1635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for porting the changes back over here. |
shakuzen
added
the
spring-boot change
|
@shakuzen Rebase showed no changes so I edited the target/base branch of the PR. Let me know if I need to do anything else. |
After changing the target, there are commits and changed files added to the pull request. Just to share, the steps I take to rebase for the new target branch in this case are: # on the branch for this pull request
# it was targeting master so make sure it has the latest
git rebase master
# move only pull request commits to 1.3.x
git rebase --onto 1.3.x master newrelic-spring-legacy
# resolve conflicts, if anyI'll go ahead and do that so this PR is unblocked. |
Updates for New Relic properties added in Micrometer v1.3.0 related to micrometer-metrics#1588<micrometer-metrics#1588>
shakuzen
force-pushed
the
newrelic-spring-legacy
branch
from
4127e3a to
1a024e7
Compare
shakuzen
approved these changes
Oct 30, 2019
|
@shakuzen Thank you for sharing. I have not had to do that before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates for New Relic properties added in Micrometer v1.3.0 related to
spring-projects/spring-boot#18472 per @shakuzen comment