Use Prometheus BOMs for dependency management #5468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also polishes dependencies configuration a bit along the way.
shakuzen
requested changes
Sep 9, 2024
dependencies.gradle
Outdated
| libs.junitBom | ||
| libs.junitBom, | ||
| libs.prometheusMetricsBom, | ||
| libs.prometheusSimpleClientBom |
There was a problem hiding this comment.
This will end up applying the Prometheus BOMs to all modules, but the Prometheus BOMs should only be needed in the Prometheus modules. Historically we did this kind of global management of dependencies, but I think for new changes, it will be better to keep it more focused where it makes sense and ultimately use this global dependencies.gradle less and less. So, I would remove the Prometheus BOMs from here and apply the right one in the corresponding Prometheus module instead.
shakuzen
approved these changes
Sep 10, 2024
shakuzen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes to use the Prometheus BOMs.
This PR also polishes dependencies configuration a bit along the way.