Further deprecate the handler API #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcingrzejszczak
force-pushed
the
issues_#371
branch
from
5892b02 to
fce71d2
Compare
| @@ -302,9 +306,9 @@ public InMemoryBraveSetup register(ObservationRegistry registry) { | |||
| Tracer tracer = this.tracer != null ? this.tracer.apply(tracing) : tracer(tracing); | |||
| HttpTracing httpTracing = this.httpTracing != null ? this.httpTracing.apply(tracing) : httpTracing(tracing); | |||
| HttpServerHandler httpServerHandler = this.httpServerHandler != null | |||
| ? this.httpServerHandler.apply(httpTracing) : httpServerHandler(httpTracing); | |||
There was a problem hiding this comment.
This is a breaking change but I don't think anyone uses this ™️
| @@ -318,9 +320,9 @@ public InMemoryOtelSetup register(ObservationRegistry registry) { | |||
| Tracer tracer = this.tracer != null ? this.tracer.apply(openTelemetrySdk) : tracer(openTelemetrySdk); | |||
| OtelTracer otelTracer = this.otelTracer != null ? this.otelTracer.apply(tracer) : otelTracer(tracer); | |||
| HttpServerHandler httpServerHandler = this.httpServerHandler != null | |||
| ? this.httpServerHandler.apply(openTelemetrySdk) : httpServerHandler(openTelemetrySdk); | |||
There was a problem hiding this comment.
This is a breaking change but I don't think anyone uses this ™️
| @@ -372,9 +372,9 @@ public WavefrontBraveSetup register(MeterRegistry meterRegistry, ObservationRegi | |||
| Tracer tracer = this.tracer != null ? this.tracer.apply(tracing) : tracer(tracing); | |||
| HttpTracing httpTracing = this.httpTracing != null ? this.httpTracing.apply(tracing) : httpTracing(tracing); | |||
| HttpServerHandler httpServerHandler = this.httpServerHandler != null | |||
| ? this.httpServerHandler.apply(httpTracing) : httpServerHandler(httpTracing); | |||
There was a problem hiding this comment.
This is a breaking change but I don't think anyone uses this ™️
| @@ -379,9 +381,9 @@ public WavefrontOtelSetup register(ObservationRegistry observationRegistry, Mete | |||
| ? this.customizers : (b, t) -> { | |||
| }; | |||
| HttpServerHandler httpServerHandler = this.httpServerHandler != null | |||
| ? this.httpServerHandler.apply(openTelemetrySdk) : httpServerHandler(openTelemetrySdk); | |||
There was a problem hiding this comment.
This is a breaking change but I don't think anyone uses this ™️
| HttpServerHandler httpServerHandler = this.httpServerHandler != null | ||
| ? this.httpServerHandler.apply(httpTracing) : httpServerHandler(httpTracing); |
There was a problem hiding this comment.
This is a breaking change but I don't think anyone uses this ™️
| @@ -390,9 +394,9 @@ public ZipkinOtelSetup register(ObservationRegistry registry) { | |||
| : tracer(openTelemetrySdk); | |||
| OtelTracer otelTracer = this.otelTracer != null ? this.otelTracer.apply(tracer) : otelTracer(tracer); | |||
| HttpServerHandler httpServerHandler = this.httpServerHandler != null | |||
| ? this.httpServerHandler.apply(openTelemetrySdk) : httpServerHandler(openTelemetrySdk); | |||
There was a problem hiding this comment.
This is a breaking change but I don't think anyone uses this ™️
| log.warn("The class <{}> is scheduled for removal in the next minor. Please migrate away from using it.", | ||
| clazz); | ||
| try { | ||
| Thread.sleep(5_000); |
There was a problem hiding this comment.
I would not do this and only leave the WARN message, I think that should be noisy enough (same or the other one in the otel bridge).
- whenever the deprecated API is being used added logging of warnings - also removed any calls to the deprecated API from the existing integration tests. That's a breaking change in the way that we're not creating the default handlers in testing framework. I think that's fine cause we haven't setup any functionality for it neither have we documented any of its usage anywhere fixes gh-371
marcingrzejszczak
force-pushed
the
issues_#371
branch
from
fce71d2 to
d805502
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whenever the deprecated API is being used
also removed any calls to the deprecated API from the existing integration tests. That's a breaking change in the way that we're not creating the default handlers in testing framework. I think that's fine cause we haven't setup any functionality for it neither have we documented any of its usage anywhere
fixes gh-371