Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make OtelSpan publicly accessible #809

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

ThomasVitale
Copy link
Contributor

Fixes gh-808

@marcingrzejszczak
Copy link
Contributor

Yup, we should be consistent. @ThomasVitale this isn't really a bug, can we make this patch the main branch and be added as a feature?

Fixes micrometer-metricsgh-808

Signed-off-by: Thomas Vitale <ThomasVitale@users.noreply.github.com>
@ThomasVitale
Copy link
Contributor Author

@marcingrzejszczak I've just updated the PR to target the main branch, so to include this change in 1.4.0. Thanks for the review!

@jonatan-ivanov jonatan-ivanov added enhancement New feature or request and removed enhancement New feature or request labels Sep 19, 2024
@jonatan-ivanov jonatan-ivanov removed this from the 1.4.0-RC1 milestone Sep 19, 2024
@jonatan-ivanov jonatan-ivanov merged commit 65e2c9e into micrometer-metrics:main Sep 19, 2024
5 checks passed
@jonatan-ivanov
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make OtelSpan public instead of package-private
3 participants