Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variable number of detection heads #75

Merged
merged 23 commits into from
Dec 17, 2023
Merged

Variable number of detection heads #75

merged 23 commits into from
Dec 17, 2023

Conversation

matteobeltrami
Copy link
Collaborator

No description provided.

fpaissan
fpaissan reviewed Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@fpaissan fpaissan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. The changes seem good. I just pointed out some minor things that need fixing (mainly docstring and some commenting). Once these changes are done, I will try to run the recipe in a clean environment to ensure everything is fine! :)

micromind/networks/yolo.py Outdated Show resolved Hide resolved
micromind/networks/yolo.py Outdated Show resolved Hide resolved
micromind/networks/yolo.py Show resolved Hide resolved
micromind/networks/yolo.py Outdated Show resolved Hide resolved
micromind/networks/yolo.py Show resolved Hide resolved
micromind/utils/yolo.py Show resolved Hide resolved
recipes/object_detection/train.py Outdated Show resolved Hide resolved
recipes/object_detection/train.py Show resolved Hide resolved
fpaissan
fpaissan approved these changes Dec 17, 2023
View reviewed changes
Copy link
Collaborator

@fpaissan fpaissan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me now. Tested for VOC, COCO, and COCO8.

Feel free to merge, thanks! :)

@matteobeltrami matteobeltrami merged commit 2ba9318 into micromind-toolkit:dev Dec 17, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpaissan fpaissan fpaissan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matteobeltrami @fpaissan