Process constructors regradless of builder. Fixes #11432

micronaut-projects · Dec 17, 2024 · 9ae2e07 · 9ae2e07
1 parent 40478d2
commit 9ae2e07
Show file tree

Hide file tree

Showing 3 changed files with 38 additions and 13 deletions.
diff --git a/...essor/src/main/java/io/micronaut/inject/beans/visitor/IntrospectedTypeElementVisitor.java b/...essor/src/main/java/io/micronaut/inject/beans/visitor/IntrospectedTypeElementVisitor.java
@@ -205,7 +205,7 @@ private void processBuilderDefinition(ClassElement element, VisitorContext conte
                 throw new ElementPostponedToNextRoundException(element);
             }
             String creatorMethod = lombokBuilder.stringValue("buildMethodName").orElse("build");
-            String[] writePrefixes = lombokBuilder.stringValue("setterPrefix").map(sp -> new String[] { sp }).orElse(new String[]{""});
+            String[] writePrefixes = lombokBuilder.stringValue("setterPrefix").map(sp -> new String[]{sp}).orElse(new String[]{""});
             processBuilderDefinition(
                 element,
                 context,
@@ -420,18 +420,13 @@ private void processElement(boolean metadata,
         List<PropertyElement> beanProperties = ce.getBeanProperties(propertyElementQuery).stream()
             .filter(p -> !p.isExcluded())
             .toList();
-        // unfortunately sometimes we don't see the Lombok transformations
-        // so assume if the class is annotated with Lombok builder we cannot
-        // access the constructor.
-        if (!ce.hasDeclaredAnnotation(ANN_LOMBOK_BUILDER)) {
-            Optional<MethodElement> constructorElement = ce.getPrimaryConstructor();
-            constructorElement.ifPresent(constructorEl -> {
-                if (ArrayUtils.isNotEmpty(constructorEl.getParameters())) {
-                    writer.visitConstructor(constructorEl);
-                }
-            });
-            ce.getDefaultConstructor().ifPresent(writer::visitDefaultConstructor);
-        }
+        Optional<MethodElement> constructorElement = ce.getPrimaryConstructor();
+        constructorElement.ifPresent(constructorEl -> {
+            if (ArrayUtils.isNotEmpty(constructorEl.getParameters())) {
+                writer.visitConstructor(constructorEl);
+            }
+        });
+        ce.getDefaultConstructor().ifPresent(writer::visitDefaultConstructor);
 
         for (PropertyElement beanProperty : beanProperties) {
             if (beanProperty.isExcluded()) {

diff --git a/test-suite/src/test/java/io/micronaut/test/lombok/LombokIntrospectedBuilderTest.java b/test-suite/src/test/java/io/micronaut/test/lombok/LombokIntrospectedBuilderTest.java
@@ -1,8 +1,12 @@
 package io.micronaut.test.lombok;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 
+import io.micronaut.core.beans.BeanConstructor;
 import io.micronaut.core.beans.BeanIntrospection;
+import io.micronaut.core.beans.BeanProperty;
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.Test;
 
@@ -11,6 +15,23 @@
 
 public class LombokIntrospectedBuilderTest {
 
+    @Test
+    void testLombokRecordBuilder() {
+        BeanIntrospection<RobotRecord> introspection = BeanIntrospection.getIntrospection(RobotRecord.class);
+
+        assertTrue(introspection.hasBuilder());
+        BeanProperty<RobotRecord, String> property =
+            introspection.getRequiredProperty("name", String.class);
+
+        assertTrue(property.hasSetterOrConstructorArgument());
+        BeanConstructor<RobotRecord> constructor = introspection.getConstructor();
+        assertNotNull(constructor);
+        assertEquals(1, constructor.getArguments().length);
+
+        RobotRecord robot = introspection.instantiate("test");
+        assertEquals("test", robot.name());
+    }
+
     @Test
     void testLombokBuilder() {
         BeanIntrospection.Builder<RobotEntity> builder = BeanIntrospection.getIntrospection(RobotEntity.class)

diff --git a/test-suite/src/test/java/io/micronaut/test/lombok/RobotRecord.java b/test-suite/src/test/java/io/micronaut/test/lombok/RobotRecord.java
@@ -0,0 +1,9 @@
+package io.micronaut.test.lombok;
+
+import io.micronaut.core.annotation.Introspected;
+import lombok.Builder;
+
+@Introspected
+@Builder
+public record RobotRecord(String name) {
+}