Fix build with JCenter removal #10990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCenter is now redirecting to Maven Central, so it doesn't serve artifacts which were only in JCenter anymore. Of course, our build had such an artifact. It was brought through the "webdrivers" plugin, which depends on a grolifant version which is not on Maven Central. Unfortunately, upgrading that plugin is not straightforward. While there is an alternative, there is actually no version which is compatible with Gradle 8.7: erdi/webdriver-binaries-gradle-plugin#43 At the same time, the `test-geb` module was actually not tested on CI. The only way to run the tests was locally, and the instructions to do so were wrong, so it's unlikely that it gave any useful signal anywhere recently. As such, this commit removes the `test-suite-geb` module, at least until we have a proper replacement. Fixes #10988
alvarosanchez
approved these changes
Jul 17, 2024
|
graemerocher
pushed a commit
that referenced
this pull request
Jul 22, 2024
JCenter is now redirecting to Maven Central, so it doesn't serve artifacts which were only in JCenter anymore. Of course, our build had such an artifact. It was brought through the "webdrivers" plugin, which depends on a grolifant version which is not on Maven Central. Unfortunately, upgrading that plugin is not straightforward. While there is an alternative, there is actually no version which is compatible with Gradle 8.7: erdi/webdriver-binaries-gradle-plugin#43 At the same time, the `test-geb` module was actually not tested on CI. The only way to run the tests was locally, and the instructions to do so were wrong, so it's unlikely that it gave any useful signal anywhere recently. As such, this commit removes the `test-suite-geb` module, at least until we have a proper replacement. Fixes #10988
timyates
referenced
this pull request
in apache/groovy
Aug 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JCenter is now redirecting to Maven Central, so it doesn't serve artifacts which were only in JCenter anymore. Of course, our build had such an artifact. It was brought through the "webdrivers" plugin, which depends on a grolifant version which is not on Maven Central.
Unfortunately, upgrading that plugin is not straightforward. While there is an alternative, there is actually no version which is compatible with Gradle 8.7:
erdi/webdriver-binaries-gradle-plugin#43
At the same time, the
test-gebmodule was actually not tested on CI. The only way to run the tests was locally, and the instructions to do so were wrong, so it's unlikely that it gave any useful signal anywhere recently.As such, this commit removes the
test-suite-gebmodule, at least until we have a proper replacement.Fixes #10988