Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to elasticsearch-java 8 #320

Merged
merged 1 commit into from
May 16, 2022

Conversation

altro3
Copy link
Contributor

@altro3 altro3 commented May 9, 2022

Removed the use of RestHighLevelClient and xcontent

Fixes #305

gradle.properties Outdated Show resolved Hide resolved
@altro3 altro3 force-pushed the elasticsearch8 branch 4 times, most recently from ecc2cf3 to 178669c Compare May 9, 2022 15:01
@altro3
Copy link
Contributor Author

altro3 commented May 9, 2022

@graemerocher sorry, I don't understand what does it mean:

Execution failed for task ':elasticsearch:japiCmp'.
> A failure occurred while executing me.champeau.gradle.japicmp.JApiCmpWorkAction
   > Detected binary changes.
         - current: elasticsearch-5.0.0-SNAPSHOT.jar
         - baseline: micronaut-elasticsearch-4.2.0.jar.

How to fix it?

@graemerocher
Copy link
Contributor

This is because the changes are binary incompatible with the previous release. To resolve this the changes have to accepted with a file like:

https://github.com/micronaut-projects/micronaut-core/blob/3.4.x/config/accepted-api-changes.json

You can run ./gradlew elasticsearch:japiCmp and open the report to see example JSON snippets that need to be included in this PR to accept the changes.

We have this in place to prevent breaking binary incompatibility in projects

@altro3 altro3 force-pushed the elasticsearch8 branch 4 times, most recently from a3d287c to b1966ce Compare May 11, 2022 10:03
@altro3
Copy link
Contributor Author

altro3 commented May 11, 2022

@graemerocher thanks! Now all fixed

@graemerocher graemerocher requested review from timyates and sdelamo May 11, 2022 12:43
@graemerocher
Copy link
Contributor

@timyates This module upgrade features a breaking major version upgrade so we would only be able to include in the BOM from Micronaut 4.0 onwards

@graemerocher
Copy link
Contributor

/cc @sdelamo

@timyates timyates mentioned this pull request May 12, 2022
@graemerocher
Copy link
Contributor

it should indeed

gradle.properties Outdated Show resolved Hide resolved
@timyates
Copy link
Contributor

Other than the core branch version, it lgtm

I pushed a branch to get sonar to check it, and sonar likes it too

image

@graemerocher graemerocher merged commit 48e0b0c into micronaut-projects:master May 16, 2022
sdelamo added a commit that referenced this pull request Aug 2, 2022
@sdelamo sdelamo added the type: breaking Introduces a breaking change label Aug 2, 2022
sdelamo added a commit that referenced this pull request Aug 2, 2022
sdelamo added a commit that referenced this pull request Aug 2, 2022
…HighLevelClient and xcontent (#320)""

This reverts commit ddb0a78.
sdelamo added a commit that referenced this pull request Apr 12, 2023
Port of changes in #320 which were lost in merge
graemerocher pushed a commit that referenced this pull request Apr 12, 2023
Port of changes in #320 which were lost in merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: breaking Introduces a breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add elasticsearch 8.x support
4 participants