-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to elasticsearch-java 8 #320
Conversation
ecc2cf3
to
178669c
Compare
@graemerocher sorry, I don't understand what does it mean:
How to fix it? |
This is because the changes are binary incompatible with the previous release. To resolve this the changes have to accepted with a file like: https://github.com/micronaut-projects/micronaut-core/blob/3.4.x/config/accepted-api-changes.json You can run We have this in place to prevent breaking binary incompatibility in projects |
a3d287c
to
b1966ce
Compare
@graemerocher thanks! Now all fixed |
@timyates This module upgrade features a breaking major version upgrade so we would only be able to include in the BOM from Micronaut 4.0 onwards |
/cc @sdelamo |
it should indeed |
Other than the core branch version, it lgtm I pushed a branch to get sonar to check it, and sonar likes it too |
…and xcontent Fixes 305
Port of changes in #320 which were lost in merge
Port of changes in #320 which were lost in merge
Removed the use of RestHighLevelClient and xcontent
Fixes #305