Fix graalvm download url #1041
Merged
Fix graalvm download url #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the Gradle's counterpart to micronaut-projects/micronaut-maven-plugin#1219 The fix is slightly different since we already had a way to define the base path, but not the full path. Now the plugin provides the option to completely override the GraalVM download URL, in case the derivation from the JDK and arch properties is not good enough.
alvarosanchez
approved these changes
Oct 22, 2024
|
melix
added a commit
that referenced
this pull request
Oct 22, 2024
* Fix GraalVM download URL This is the Gradle's counterpart to micronaut-projects/micronaut-maven-plugin#1219 The fix is slightly different since we already had a way to define the base path, but not the full path. Now the plugin provides the option to completely override the GraalVM download URL, in case the derivation from the JDK and arch properties is not good enough. * Update Amazon Linux base image
| @@ -431,13 +460,13 @@ private void setupInstructions(List<Instruction> additionalInstructions) { | |||
| if (buildStrategy == DockerBuildStrategy.LAMBDA) { | |||
| from(new From(imageResolver.resolve()).withStage("graalvm")); | |||
| environmentVariable("LANG", "en_US.UTF-8"); | |||
| runCommand("yum install -y gcc gcc-c++ glibc-devel glibc-langpack-en curl-minimal bash zlib zlib-devel zlib-static zip tar gzip"); | |||
| runCommand("dnf update -y && dnf install -y gcc glibc-devel zlib-devel libstdc++-static tar && dnf clean all && rm -rf /var/cache/dnf"); | |||
There was a problem hiding this comment.
I'm getting an error message here when building now, looks like it wants gzip
Step 5/40 : RUN tar -zxf /tmp/graalvm-jdk-21_linux-aarch64_bin.tar.gz -C /tmp && ls -d /tmp/graalvm-jdk-21* | grep -v "tar.gz" | xargs -I_ mv _ /usr/lib/graalvm
---> Running in b86271e6df5a
tar (child): gzip: Cannot exec: No such file or directory
tar (child): Error is not recoverable: exiting now
There was a problem hiding this comment.
Nevermind, it looks like the image was changed to 2023-minimal, I had it set to amazonlinux:2023. Works with the new image.
There was a problem hiding this comment.
@melix since the Gradle plugin allows changing this base image, you should change it to install gzip. That will work for both images.
Note that the change to the minimal image is intentional and more correct, since it is what AWS uses in the provided runtime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.