Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build to use the new core-bom #142

Merged
merged 8 commits into from
Dec 6, 2022
Merged

Update build to use the new core-bom #142

merged 8 commits into from
Dec 6, 2022

Conversation

timyates
Copy link
Contributor

We now need to import the catalogs from any module we consume, they are no longer provided in core.

We cannot pull the platform bom, as this would introduce a circular dependency.

We now need to import the catalogs from any module we consume, they are no longer provided in core.

We cannot pull the platform bom, as this would introduce a circular dependency.
@timyates timyates added the relates-to: build label for issues related to the build file or CI label Nov 21, 2022
@timyates timyates added this to the 2.0.0 milestone Nov 21, 2022
@timyates timyates self-assigned this Nov 21, 2022
@timyates
Copy link
Contributor Author

Something is caching the snapshot 🤔

locally, I can use mn.snakeyaml in the test-suite builds, but here I cannot...

@sdelamo can you think what may be holding onto old snapshots?

Or see what I've done wrong?

@timyates
Copy link
Contributor Author

timyates commented Dec 6, 2022

If this goes green I'm going to merge it as it's just updating the build to the latest settings style, and renovate PRs are starting to pile up behind it

@timyates
Copy link
Contributor Author

timyates commented Dec 6, 2022

hehe, once the license/cla action finishes 🫠

@radovanradic
Copy link

hehe, once the license/cla action finishes 🫠

It happened to me some time ago. I had to commit something dummy (like new line, space or something) to trigger new build that completed then ¯\(ツ)

@sonarcloud
Copy link

sonarcloud bot commented Dec 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@timyates
Copy link
Contributor Author

timyates commented Dec 6, 2022

@radovanradic Good call 😎

@timyates timyates merged commit f7c0144 into master Dec 6, 2022
@timyates timyates deleted the fix-logging branch December 6, 2022 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relates-to: build label for issues related to the build file or CI
Projects
No open projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants