Stop declaring a version of reactor-test #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And instead rely on the version from micronaut-reactor
timyates
added
the
relates-to: build
melix
reviewed
Dec 6, 2022
timyates
added a commit
to micronaut-projects/micronaut-reactor
that referenced
this pull request
Dec 8, 2022
When switching microstream to the latest build for micronaut 4.0.0, it raised an issue micronaut-projects/micronaut-microstream#144 We could pull reactor-core from the core-bom, but as it didn't contain reactor-test we had to jump through hoops. In #248 we swiched to using the reactor bom instead of managed dependencies. But as the reactor-bom hard-codes versions instead of setting them as properties we need to specify the version of reactor-core and reactor-test that we want to include. The downside here is we will need to keep them in sync whenever the BOM version gets updated
Requires a snapshot from micronaut-projects/micronaut-core#8470
timyates
added
the
status: awaiting third-party
|
As discussed, switched to adding reactor-test to the core bom in micronaut-projects/micronaut-core#8470 This should pass once we get a snapshot with that published |
|
Kudos, SonarCloud Quality Gate passed!
|
melix
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And instead rely on the version from micronaut-reactor