wip: Alternative Storage Target support #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timyates
changed the title
|
Extracted a base interface |
sdelamo
reviewed
May 20, 2023
...ostream/src/main/java/io/micronaut/microstream/s3/DefaultS3StorageConfigurationProvider.java
Outdated
Show resolved
Hide resolved
...ostream/src/main/java/io/micronaut/microstream/s3/DefaultS3StorageConfigurationProvider.java
Show resolved
Hide resolved
...ostream/src/main/java/io/micronaut/microstream/s3/DefaultS3StorageConfigurationProvider.java
Outdated
Show resolved
Hide resolved
|
@sdelamo I believe this is ready for review 🤞 |
sdelamo
approved these changes
May 24, 2023
microstream/src/main/java/io/micronaut/microstream/s3/S3StorageConfigurationProvider.java
Outdated
Show resolved
Hide resolved
| @Bean | ||
| @Singleton | ||
| @Named(OTHER_CLIENT_NAME) | ||
| S3Client buildClient() { |
There was a problem hiding this comment.
It is more correct to pass to the factory method the bean dependency instead of to the factory constructor because it clearly defines the bean hierarchy.
Suggested change
| S3Client buildClient() { | |
| S3Client buildClient(S3Config s3Config) { |
There was a problem hiding this comment.
I have changed it here: 350e6d5
…eConfigurationProvider.java
|
@timyates I have flagged the tests which require docker and extract some test utils |
timyates
commented
May 24, 2023
test-suite-utils/src/main/java/io/microstream/testutils/LocalStackUtils.java
Outdated
Show resolved
Hide resolved
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.