CSRF (Cross Site Request Forgery) Protection #1826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graemerocher
approved these changes
Oct 25, 2024
yawkat
approved these changes
Oct 28, 2024
dstepanov
requested changes
Oct 28, 2024
security-csrf/src/main/java/io/micronaut/security/csrf/filter/CsrfFilter.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| boolean shouldTheFilterProcessTheRequestAccordingToTheUriMatch(String uri) { | ||
| boolean matches = PathMatcher.REGEX.matches(csrfFilterConfiguration.getRegexPattern(), uri); |
There was a problem hiding this comment.
Compile the pattern and store in a field
There was a problem hiding this comment.
That it is what RegexPathMatcher does. It stores it in a concurrent hash map.
security-csrf/src/main/java/io/micronaut/security/csrf/filter/CsrfFilter.java
Show resolved
Hide resolved
| } | ||
|
|
||
| @Override | ||
| public String getRegexPattern() { |
There was a problem hiding this comment.
Maybe have the property named regex and regexPattern will return an instance of Pattern?
There was a problem hiding this comment.
I think the name regex-pattern is appropriate. I want to convey is the pattern used for the filter. And I want to convey it is a regular expression not an ant pattern.
The patterns this filter should match
security-csrf/src/main/java/io/micronaut/security/csrf/generator/CsrfHmacTokenGenerator.java
Show resolved
Hide resolved
...rity-csrf/src/main/java/io/micronaut/security/csrf/session/HttpSessionSessionIdResolver.java
Outdated
Show resolved
Hide resolved
...ty-csrf/src/main/java/io/micronaut/security/csrf/validator/RepositoryCsrfTokenValidator.java
Outdated
Show resolved
Hide resolved
...src/main/java/io/micronaut/security/token/jwt/validator/JsonWebTokenIdSessionIdResolver.java
Outdated
Show resolved
Hide resolved
security-session/src/main/java/io/micronaut/security/session/DefaultSessionPopulator.java
Outdated
Show resolved
Hide resolved
security/src/main/java/io/micronaut/security/session/CompositeSessionIdResolver.java
Outdated
Show resolved
Hide resolved
|
dstepanov
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this PR gets merged, I will do a PR in Views to add a ViewModelProcessor which adds the CSRF token to the views seamlessly. I will also explore add it to the form generation api.