Run "Update AL-Go System Files" on multiple branches #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mazhelez
commented
May 14, 2024
freddydk
reviewed
Jun 21, 2024
Templates/Per Tenant Extension/.github/workflows/UpdateGitHubGoSystemFiles.yaml
Outdated
Show resolved
Hide resolved
…-al-go-multiple-branches
…-al-go-multiple-branches
mazhelez
changed the title
spetersenms
previously approved these changes
Feb 10, 2025
mazhelez
commented
Feb 10, 2025
Actions/GetWorkflowMultiRunBranches/GetWorkflowMultiRunBranches.ps1
Outdated
Show resolved
Hide resolved
mazhelez
commented
Feb 10, 2025
mazhelez
commented
Feb 10, 2025
mazhelez
commented
Feb 10, 2025
Update doc
freddydk
requested changes
Feb 11, 2025
|
|
||
| When run on a schedule, _Update AL-Go System Files_ only runs on the _main_ branch. By setting `includeBranches` in `workflowSchedule` setting, you can now run the workflow on a schedule on multiple branches. Read more at https://aka.ms/algosecrets#workflowSchedule. | ||
|
|
||
| Dispatching the workflow manually still runs the workflow only on the branch it was dispatched on. |
There was a problem hiding this comment.
The includeBranches is also available when running manually right?
There was a problem hiding this comment.
The input takes priority when dispatching the workflow.
So, there's includeBranches input: used when running manually.
workflowSchedule.includeBranches setting: used when running on a schedule.
I had an iteration where the input was something like "run the same way as scheduled", but I quickly realized how it can be confusing. Especially when there's also commitOptions setting.
Templates/AppSource App/.github/workflows/UpdateGitHubGoSystemFiles.yaml
Show resolved
Hide resolved
…-al-go-multiple-branches
…azhelez/AL-Go into update-al-go-multiple-branches
mazhelez
commented
Feb 20, 2025
| @@ -705,6 +705,10 @@ function ReadSettings { | |||
| "messageSuffix" = "" | |||
| "pullRequestAutoMerge" = $false | |||
| "pullRequestLabels" = @() | |||
| "createPullRequest" = $true | |||
| } | |||
| "workflowSchedule" = [ordered] @{ | |||
There was a problem hiding this comment.
Probably don't need to add it in default settings.
mazhelez
commented
Feb 20, 2025
| switch ($env:GITHUB_EVENT_NAME) { | ||
| 'schedule' { | ||
| Write-Host "Event is schedule: getting branches from settings" | ||
| $branchPatterns = @($($(ConvertFrom-Json $env:settings).workflowSchedule.includeBranches)) |
There was a problem hiding this comment.
Add defensive check in case workflowSchedule or includeBranches is not defined.
mazhelez
commented
Feb 20, 2025
| @@ -63,7 +63,7 @@ $settings.Keys | ForEach-Object { | |||
| } | |||
| $outSettings += @{ "$setting" = $settingValue } | |||
| if ($getSettings -contains $setting) { | |||
| if ($settingValue -is [System.Collections.Specialized.OrderedDictionary] -or $settingValue -is [hashtable]) { | |||
| if ($settingValue -is [System.Collections.Specialized.OrderedDictionary] -or $settingValue -is [hashtable] -or $settingValue -is [array]) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: When scheduling "Update AL-Go System Files" workflow, it runs only on the default branch (GitHub Actions limitation).
This PR alters the workflow to be able to schedule "Update AL-Go System Files" to run on multiple branches.
Manually dispatching the workflow isn't changed.
New property
workflowSchedulesetting,includeBranches, is added to specify the branches when running the workflow on a schedule.