-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow GitHubRunner as a project setting #1177
Conversation
These lines at the end of ReadSettings should be removed:
and these lines in the corresponding action.yaml:
and these lines in the corresponding readme.md should be replaced by
Nobody should use this output. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - I like the change
Added a comment with requested changes (to remove the outputs from ReadSettings)
…1/al-go into aholstrup/githubrunner
So.. We're still using these outputs a couple of places. Specifically, in BuildPP: AL-Go/Templates/Per Tenant Extension/.github/workflows/CICD.yaml Lines 174 to 175 in 67b4489
And CreateDevelopmentEnvironment AL-Go/Templates/AppSource App/.github/workflows/CreateOnlineDevelopmentEnvironment.yaml Line 103 in 67b4489
How do we get rid of those dependencies in an appropriate way? For PP we could output the runner + runnerShell from: AL-Go/Templates/Per Tenant Extension/.github/workflows/CICD.yaml Lines 82 to 86 in 520a241
Maybe we can do something similar for CreateDevelopmentEnvironment. Thoughts? Something like this: |
Allow GitHubRunner as a project setting. This would enable us to compile apps on linux-based GitHub runners while running the tests on either windows GitHub runners or self-hosted runners.
Allow GitHubRunner as a project setting. This would enable us to compile apps on linux-based GitHub runners while running the tests on either windows GitHub runners or self-hosted runners.
Allow GitHubRunner as a project setting. This would enable us to compile apps on linux-based GitHub runners while running the tests on either windows GitHub runners or self-hosted runners.