Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write output of sign install to log #1270

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Write output of sign install to log #1270

merged 3 commits into from
Oct 25, 2024

Conversation

aholstrup1
Copy link
Collaborator

  • Update the Sign script to log the output of dotnet install to the logs.
  • Update the sign package to latest. The Sign team recently made an improvement to write a warning if Visual C++ Runtime is not installed. If it isn't, signing will fail because NavSip depends on this assembly.

Related to #1252

@aholstrup1 aholstrup1 requested a review from a team as a code owner October 22, 2024 14:04
@aholstrup1 aholstrup1 changed the title Private/aholstrup/algosigning Write output of sign install to log Oct 22, 2024
mazhelez
mazhelez previously approved these changes Oct 22, 2024
View reviewed changes
freddydk
freddydk reviewed Oct 23, 2024
View reviewed changes
Actions/Sign/Sign.psm1 Outdated Show resolved Hide resolved
freddydk
freddydk reviewed Oct 23, 2024
View reviewed changes
Actions/Sign/Sign.psm1 Outdated Show resolved Hide resolved
freddydk
freddydk previously approved these changes Oct 23, 2024
View reviewed changes
@aholstrup1 aholstrup1 dismissed stale reviews from freddydk and mazhelez via dcd94bc October 23, 2024 08:04
@aholstrup1 aholstrup1 enabled auto-merge (squash) October 23, 2024 09:56
@aholstrup1 aholstrup1 merged commit df9e7c1 into microsoft:main Oct 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freddydk freddydk freddydk approved these changes

@mazhelez mazhelez mazhelez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aholstrup1 @freddydk @mazhelez