Page Scripting test result visualizer & updated test analyzer logic. #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This can't be fully tested yet, due to a current dependency error in bc-replay which fails on install. |
mazhelez
reviewed
Jan 29, 2025
| @@ -14,6 +14,7 @@ none | |||
| | :-- | :-: | :-- | :-- | | |||
| | shell | | The shell (powershell or pwsh) in which the PowerShell script in this action should run | powershell | | |||
| | project | Yes | Name of project to analyze or . if the repository is setup for single project | | | |||
| | testsToAnalyze | No | Which set of tests to analyze. Should be one of ('app', 'bcpt', 'pageScripting') | app | | |||
|
|
|||
| ## OUTPUT | |||
There was a problem hiding this comment.
I don't think the action has output. OUTPUT variables might need to be cleaned up.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added functionality to visualize page scripting tests, similar to how app and bcpt tests are visualized as MD.
I also updated the test analyzer action to take a new param, which decides which of those 3 types of tests to analyze and visualize.
I think this is a better approach that a separate action for analyzing page scripting tests, as it is nearly identical in implementation.
This approach also splits the analyzer visualization step into 3 separate steps, for each of the 3 types. This have the advantage, that we can easily add new test types to the analyzer in the future, but we are also more likely to display the results in the build summary. As each step has a limit of 1MiB, the current approach of displaying both app and bcpt results in the same step, are more likely to reach that limit. Now each summary for each type have a separate limit of 1MiB.