-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rule AA0232 for Enums #6348
Comments
When do you think this might get corrected? |
@PaulIvan can you provide an ETA? |
Still no update :-( |
Hi @NKarolak I agree this looks a bit weird but just because something is possible doesn't mean it should be used. I'm just a bit confused as to why a lookup flowfield wouldn't be better in this case? |
I guess the example code is deliberately oversimplified, to the point of being nonsensical in practice, but it demonstrates the issue in theory. That said, it seems brittle to rely on the numeric values of enums or options, and I never like it when I find code that does that. Did adding to a SIFT key work with options? If not, I guess it was never intended to work. I'd almost say that min/max should be disallowed on enums/options, for the reason above, but presumably that can't happen as it'd annoy too many people writing that kind of code ;-) |
@DTKB |
@PaulIvan Can you give an ETA? |
@qutreson push ;-) |
Thanks for reporting this issue. Sorry we haven’t completed it yet, but we’ve had to prioritize elsewhere. We’re planning to give the CodeCop engine and its rules an overhaul in a future major release. Thanks for your patience. Going forward we will not track progress on CodeCop issues here on GitHub. Hence, we are closing this issue. |
Describe the bug
The rule AA0232
is raised on Enum fields although they cannot be created as SIFT key.
To Reproduce
Enable the CodeCop in the settings.json
New Enum
New Table 1
New Table 2 with AA0232
You cannot add the Enum field as SumIndexField in table 1:
This would raise AL0199:
which is weird since Enums are numeric.
Expected behavior
Either the warning AA0232 shall not appear, or it must be possible to use Enums as SumIndexFields.
Versions:
The text was updated successfully, but these errors were encountered: