Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextBlock <-> TextRun parity #3071

Closed
productboard-ac opened this issue Jun 17, 2019 · 4 comments
Closed

TextBlock <-> TextRun parity #3071

productboard-ac opened this issue Jun 17, 2019 · 4 comments

Comments

@productboard-ac
Copy link
Collaborator

productboard-ac commented Jun 17, 2019

Summary

All the relevant properties on TextRun should also be on TextBlock and vice versa

Requirements

  • See summary

Spec/schema

After the proposal process, update this with a link to the spec PR.

Proposed changes

Added to TextBlock

  • highlight

  • italic

  • selectAction

  • strikethrough

  • underline

Added to TextRun

  • N/A

Example

{
    "type": "AdaptiveCard",
    "version": "1.0",
    "body": [
        {
            "type": "TextBlock",
            "text": "Strike me out",
            "strikethrough": true
        }
    ],
    "$schema": "http://adaptivecards.io/schemas/adaptive-card.json"
}

Host Config

N/A

Down-level impact

Minimal. The new properties won't be respected down-level.

Host burden

N/A

@productboard-ac
Copy link
Collaborator Author

@shalinijoshi19 shalinijoshi19 added this to the 1.3 milestone Jun 21, 2019
@dclaux
Copy link
Member

dclaux commented Jul 8, 2019

I personally vote against this. These properties will conflict with Markdown support, which is precisely why we decided that RichTextBlock would not support Markdown.

@andrewleader
Copy link
Contributor

andrewleader commented Jul 12, 2019

7/12/2019 review meeting

  • David absent and Matt not sure, so postponing any decisions
  • David joined, we're split half-half, moving on for now

@ghost
Copy link

ghost commented Dec 6, 2019

This issue has been automatically marked as stale because it has not had any activity for 5 days.

@shalinijoshi19 shalinijoshi19 modified the milestones: 1.3 Release , Backlog Apr 29, 2020
@RebeccaAnne RebeccaAnne removed this from the Backlog milestone May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants