Underline support in text runs

[productboard-ac]

Release	Renderer status	Tasks status
1.3	✔️ .NET (#3215) ✔️ Android (#3216) ✔️ iOS (#3217) ✔️ TS (#3218) ✔️ UWP (#3219)	✔️ Shared (#3220) ✔️ Designer (#3221)

Summary

Add an underline property to TextRun

Requirements

• Be able to underline a text run within a RichTextBlock

Schema/spec

https://github.com/microsoft/AdaptiveCards/pull/3086/files

Proposed changes

Add an underline boolean property to TextRun. Note that depending on #3071 this property might also be added to TextBlock.

Example

{
    "type": "AdaptiveCard",
    "body": [
        {
            "type": "RichTextBlock",
            "inlines": [
                {
                    "type": "TextRun",
                    "text": "This is the first inline. "
                },
                {
                    "type": "TextRun",
                    "text": "We support underlining",
                    "underline": true
                },
                ", ",
                {
                    "type": "TextRun",
                    "color": "Good",
                    "text": "colors, "
                },
                {
                    "type": "TextRun",
                    "text": "both regular and subtle...",
                    "isSubtle": true
                }
            ]
        }
    ],
    "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
    "version": "1.2"
}

Host Config

N/A

Down-level impact

Minimal. The underline won't appear, but text still will appear.

Host burden

N/A

Auto-generated task status

• Shared
• Designer
• .NET
• Android
• iOS
• TS
• UWP

[productboard-ac]

Link to feature: https://adaptivecards-test.productboard.com/feature-board/planning/features/2323172

[andrewleader]

7/12/2019 review

• Will there ever be double underline?
  • Consensus is we can support that in future if need be, by upgrading the property to also be an enum so you could specify double

Proposal and spec approved, although the TextBlock aspect is dependent on the other convergence proposal #3071

[ghost]

This issue has been automatically marked as stale because it has not had any activity for 5 days.

[ghost]

🎉AdaptiveCards@2020.07 has been released which fixes this issue.:tada:

Handy links:

• Release Notes
• AdaptiveCards Website
• Official NPM Designer Release
• Official NPM Templating Release
• Official NPM Renderer Release
• Official Nuget Templating Release
• Official Nuget Renderer Release
• Official Maven Renderer Release
• Official CocoaPod Renderer Release