Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS][Renderer] Add TextRun.underline #4205

Merged
merged 2 commits into from
Jun 22, 2020
Merged

[TS][Renderer] Add TextRun.underline #4205

merged 2 commits into from
Jun 22, 2020

Conversation

dclaux
Copy link
Member

@dclaux dclaux commented Jun 22, 2020

Related Issue

Fixes #3051
Fixes #3218
Fixes #3221

Description

Adds the underline property to TextRun

How Verified

Verified manually in adaptivecards-designer-app

Test payload:

{
    "type": "AdaptiveCard",
    "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
    "version": "1.3",
    "body": [
        {
            "type": "RichTextBlock",
            "inlines": [
                {
                    "type": "TextRun",
                    "text": "Now you can have "
                },
                {
                    "type": "TextRun",
                    "text": "underlined text",
                    "underline": true
                },
                {
                    "type": "TextRun",
                    "text": " within a RichTextBLock"
                }
            ]
        }
    ]
}

As rendered:
image

Microsoft Reviewers: Open in CodeFlow

@ghost
Copy link

ghost commented Jun 22, 2020

Hi @dclaux. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

@dclaux
Copy link
Member Author

dclaux commented Jun 22, 2020

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@dclaux dclaux merged commit ebd1ff3 into main Jun 22, 2020
@dclaux dclaux deleted the ts/textrun-underline branch June 22, 2020 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants