[JS][Bug Bash] [ImageSet Auto Size doesn't work properly]

[jwoo-msft]

Platform

What platform is your issue or question related to? (Delete other platforms).

• JavaScript

Version of SDK

1.2.6

Details

repro steps:

1. add the below json, and paste it to designer.
2. no images will show up.
3. ctrl-a then paste it again

{
	"$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
	"type": "AdaptiveCard",
	"version": "1.0",
	"body": [
		{
			"type": "TextBlock",
			"text": "Here are some cool photos",
			"size": "large"
		},
		{
			"type": "TextBlock",
			"text": "Sorry some of them are repeats",
			"size": "medium",
			"weight": "lighter"
		},
		{
			"type": "ImageSet",
			"imageSize": "auto",
			"images": [
				{
					"type": "Image",
					"url": "https://picsum.photos/200/200?image=100"
				},
				{
					"type": "Image",
					"url": "https://picsum.photos/300/200?image=200"
				},
				{
					"type": "Image",
					"url": "https://picsum.photos/300/200?image=301"
				},
				{
					"type": "Image",
					"url": "https://picsum.photos/200/200?image=400"
				},
				{
					"type": "Image",
					"url": "https://picsum.photos/300/200?image=500"
				},
				{
					"type": "Image",
					"url": "https://picsum.photos/200/200?image=600"
				},
				{
					"type": "Image",
					"url": "https://picsum.photos/300/200?image=700"
				},
				{
					"type": "Image",
					"url": "https://picsum.photos/300/200?image=800"
				},
				{
					"type": "Image",
					"url": "https://picsum.photos/300/200?image=900"
				}
			]
		}
	]
}

some pictures are overlapped each other, and some pictures have wrong aspect ratio
JS

UWP

[dclaux]

I am not able to repro this.

[jwoo-msft]

I am not able to repro this.

you're really active! i edited the description with repro step

[shalinijoshi19]

@dclaux could you take a first pass with teh repro steps that @nesalang provides? Thanks!

[ghost]

We have acknowledged this issue report. Please continue to follow the issue for updates/progress/questions. @matthidinger / @dclaux / @RebeccaAnne / @paulcam206 FYI.

[dclaux]

auto and stretch are not supported sizes in ImageSet. But the JS renderer fails to fall back to medium in those cases, so what you're seeing is HTML doing its best to auto-size while being constrained to a maximum height for each image.

The fix will be to fall back to medium when either auto or stretch are specified as imageSIze, and to remove the option to select auto or stretch from the designer.

Note the documentation doesn't say that "auto" and "stretch" are not supported, and I can foresee my assertion they are not supported will be debated. If we're going to debate, please do include a description of how "auto" and "stretch" should work in an ImageSet.

[RebeccaAnne]

Duping to #4043