Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS-Android-Web][ImageSet Rendering] [No parity in rendering of images in imageSet for various imageSizes] #4043

Closed
3 of 6 tasks
adumrewal opened this issue May 20, 2020 · 9 comments · Fixed by #4268 or #4380
Closed
3 of 6 tasks

[iOS-Android-Web][ImageSet Rendering] [No parity in rendering of images in imageSet for various imageSizes] #4043

adumrewal opened this issue May 20, 2020 · 9 comments · Fixed by #4268 or #4380
Labels
Area-Inconsistency Bugs around renderer inconsistencies across different platforms Bug Partner-MsftTeams Issues related to AC integration with Microsoft Teams partner Partner-MsftTeamsMobile Bugs related specifically to Teams Mobile integration (iOS/Android) Platform-Android Platform-iOS Platform-JavaScript Bugs or features related to the JavaScript renderer

Comments

@adumrewal
Copy link

adumrewal commented May 20, 2020 •
edited by jwoo-msft
Loading

Platform

What platform is your issue or question related to? (Delete other platforms).

  • Android
  • iOS
  • UWP
  • JS
  • .NET
  • Documentation

Author or host

Host - Teams

What version are you using? Ex: NuGet 1.0.2, or latest master, etc...

1.2.7 on iOS

Details

When using imageSize for imageSet, there is no parity between the rendering experience on the three clients ( iOS, Android and Web). Sample JSON and screenshots are attached.

Card Number iOS Android Web
1: Large Images drawing drawing Screenshot 2020-05-20 at 1 33 24 PM
1: Small Images drawing drawing Screenshot 2020-05-20 at 1 35 28 PM

Card JSON:
Json for card with Large images:
imageSetLarge.txt

Json for card with Small images:
imageSetSmall.txt
@adumrewal adumrewal added the Bug label May 20, 2020
@ghost ghost added the Triage-Needed label May 20, 2020
@adumrewal adumrewal changed the title [Platform][Broad Issue Category if applicable (eg Accessibility)] [Bug Title] [iOS-Android-Web][ImageSet Rendering] [No parity in rendering of images in imageSet for various imageSizes] May 20, 2020
@VikrantSingh01 VikrantSingh01 added Partner-MsftTeamsMobile Bugs related specifically to Teams Mobile integration (iOS/Android) Partner-MsftTeams Issues related to AC integration with Microsoft Teams partner labels Jun 4, 2020
@shalinijoshi19 shalinijoshi19 added the Area-Inconsistency Bugs around renderer inconsistencies across different platforms label Jun 4, 2020
@shalinijoshi19
Copy link
Member

@paulcam206 this seems related to the investigation you did for #4035 no? @jwoo-msft FYI.

@ghost ghost removed the Triage-Needed label Jun 4, 2020
@ghost
Copy link

ghost commented Jun 4, 2020

Hi @adumrewal. We have acknowledged this issue report. Please continue to follow this issue for updates/progress/questions. @matthidinger / @dclaux / @RebeccaAnne / @paulcam206 / @jwoo-msft / @almedina-ms FYI.

@paulcam206
Copy link
Member

@paulcam206 this seems related to the investigation you did for #4035 no? @jwoo-msft FYI.

no -- #4035 is UWP-specific

@jwoo-msft
Copy link
Member

@almedina-ms & @golddove can you check if Android does the right thing as specified in here.

@dclaux could you please update JS renderer as was discussed here

@shalinijoshi19
Copy link
Member

shalinijoshi19 commented Jul 1, 2020 •
edited
Loading

@almedina-ms & @golddove can you check if Android does the right thing as specified in here.

@dclaux could you please update JS renderer as was discussed here

@jwoo-msft are we actually targeting this for 20.06 release ? This one will include a behavior change that will need to be documented as well and the behavior needing to be vetted for UWP/.NET to ensure it's consistent. Also am assuming iOS' behavior is consistent and the baseline behavior we want to go with?

@shalinijoshi19 shalinijoshi19 assigned golddove and dclaux and unassigned jwoo-msft Jul 1, 2020
@dclaux dclaux mentioned this issue Jul 1, 2020
Merged
@ghost ghost added the Status-In Code Review label Jul 1, 2020
@shalinijoshi19
Copy link
Member

shalinijoshi19 commented Jul 6, 2020 •
edited
Loading

Reopening to track remaining platforms

@shalinijoshi19 shalinijoshi19 reopened this Jul 6, 2020
@ghost ghost removed the Triage-Needed label Jul 6, 2020
@ghost
Copy link

ghost commented Jul 6, 2020

Hi @adumrewal. We have acknowledged this issue report. Please continue to follow this issue for updates/progress/questions.

@shalinijoshi19 shalinijoshi19 added Platform-JavaScript Bugs or features related to the JavaScript renderer Platform-Android Platform-iOS labels Jul 6, 2020
@golddove golddove mentioned this issue Jul 9, 2020
Closed
@golddove golddove mentioned this issue Jul 15, 2020
Merged
This was referenced Jul 27, 2020
Closed
Closed
@ghost
Copy link

ghost commented Aug 5, 2020

🎉AdaptiveCards@v1.2.11 has been released which fixes this issue.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Inconsistency Bugs around renderer inconsistencies across different platforms Bug Partner-MsftTeams Issues related to AC integration with Microsoft Teams partner Partner-MsftTeamsMobile Bugs related specifically to Teams Mobile integration (iOS/Android) Platform-Android Platform-iOS Platform-JavaScript Bugs or features related to the JavaScript renderer
Projects
None yet
Milestone
No milestone
7 participants
@dclaux @jwoo-msft @golddove @adumrewal @paulcam206 @shalinijoshi19 @VikrantSingh01