[UWP][Image] [Image doesn't include spacing]

[adamhewitt627]

Platform

• UWP

Version of SDK

<PackageReference Include="AdaptiveCards" Version="1.2.4" />
<PackageReference Include="AdaptiveCards.Rendering.Uwp" Version="1.2.8" />

Details

The "Image" element doesn't include any spacing set on it, but you will see spacing on a parent ColumnSet.

Reproduction

{
    "type": "AdaptiveCard",
    "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
    "version": "1.2",
    "body": [
        {
            "text": "Here's a heading",
            "type": "TextBlock",
            "weight": "Bolder"
        },
        {
            "type": "ColumnSet",
            "spacing": "ExtraLarge",
            "columns": [
                {
                    "type": "Column",
                    "width": "stretch",
                    "items": [
                        {
                            "type": "Image",
                            "url": "https://img-prod-cms-rt-microsoft-com.akamaized.net/cms/api/am/imageFileData/RE1Mu3b?ver=5c31"
                        }
                    ]
                }
            ]
        },
        {
            "type": "Image",
            "url": "https://img-prod-cms-rt-microsoft-com.akamaized.net/cms/api/am/imageFileData/RE1Mu3b?ver=5c31",
            "spacing": "ExtraLarge"
        },
        {
            "text": "And some text below",
            "type": "TextBlock",
            "wrap": true
        }
    ]
}

[shalinijoshi19]

Hmm @paulcam206 quick stab here? I ensured it does not repro on the JS renderer so indeed looks like spacing isnt being honored on the UWP stack (both Image and ImageSet do inherit the Spacing property per the schema)

[paulcam206]

sure, I'll take a look :)

[paulcam206]

for what it's worth, this doesn't repro on master, still digging :)

[paulcam206]

has to do with SetSeparatorVisibility

[shalinijoshi19]

Thanks @paulcam206! If it doesn't repro on master, should we just wait until our July 2.0 release then for this to be addressed vs porting over as a 1.2 patch?

[ghost]

Hi @adamhewitt627. We have acknowledged this issue report. Please continue to follow this issue for updates/progress/questions. @matthidinger / @dclaux / @RebeccaAnne / @paulcam206 / @jwoo-msft / @almedina-ms FYI.

[ghost]

🎉AdaptiveCards@v1.2.10 has been released which fixes this issue.:tada:

Handy links:

• Release Notes
• AdaptiveCards Website
• Official NPM Designer Release
• Official NPM Templating Release
• Official NPM Renderer Release
• Official Nuget Templating Release
• Official Nuget Renderer Release
• Official Maven Renderer Release
• Official CocoaPod Renderer Release