Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UWP] Improve performance of base64 decoding #4192

Closed
chriche-ms opened this issue Jun 18, 2020 · 3 comments · Fixed by #4193
Closed

[UWP] Improve performance of base64 decoding #4192

chriche-ms opened this issue Jun 18, 2020 · 3 comments · Fixed by #4193
Labels
Area-Performance Tracking issues around perf/renderer latency etc Bug Platform-XAML Bugs or features related to Xaml Renderer
Milestone
20.06

Comments

@chriche-ms
Copy link
Member

chriche-ms commented Jun 18, 2020 •
edited
Loading

Platform

  • Android
  • iOS
  • UWP

Author or host

Author and host. Cortana in Windows - app is both an author and host.

Version of SDK

NuGet 1.2.8

Details

CPU profiling shows that base64 decoding is slower than it could be due to inadvertent map copying and repeated map lookups. Furthermore the map could easily be replaced altogether with a more performant array.
@chriche-ms chriche-ms added the Bug label Jun 18, 2020
@ghost ghost added the Triage-Needed label Jun 18, 2020
@chriche-ms chriche-ms mentioned this issue Jun 18, 2020
Merged
@ghost
Copy link

ghost commented Jun 18, 2020

Hi @chriche-ms; We triaged and approved your bug for fixing. Please stay tuned for updates around fix progress and/or release vehicle.

@ghost
Copy link

ghost commented Jun 18, 2020

Hi @chriche-ms. We have acknowledged this issue report. Please continue to follow this issue for updates/progress/questions.

@shalinijoshi19 shalinijoshi19 added this to the 20.06 milestone Jun 18, 2020
@shalinijoshi19 shalinijoshi19 added Platform-XAML Bugs or features related to Xaml Renderer Area-Performance Tracking issues around perf/renderer latency etc labels Jun 18, 2020
@chriche-ms chriche-ms changed the title [UWP] Improve performance of UWP parsing and rendering [Shared] Improve performance of base64 decoding Jun 19, 2020
@chriche-ms chriche-ms changed the title [Shared] Improve performance of base64 decoding [UWP] Improve performance of base64 decoding Jun 19, 2020
@chriche-ms chriche-ms mentioned this issue Jun 24, 2020
Merged
@ghost
Copy link

ghost commented Jul 8, 2020 •
edited by shalinijoshi19
Loading

🎉AdaptiveCards@v1.2.10 has been released which fixes this issue.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Performance Tracking issues around perf/renderer latency etc Bug Platform-XAML Bugs or features related to Xaml Renderer
Projects
None yet
Milestone
20.06
Development

Successfully merging a pull request may close this issue.

Replace base64 decode map with an array to improve performance chriche-ms/AdaptiveCards
2 participants
@shalinijoshi19 @chriche-ms