Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UWP] Cherry pick base64 decode performance improvements #4219

Conversation

chriche-ms
Copy link
Member

@chriche-ms chriche-ms commented Jun 24, 2020

Fixes #4192
Original PR: #4193

Microsoft Reviewers: Open in CodeFlow

…soft#4193)

* Replace base64 decode map with an array to improve performance

* Remove unnecessary #include

* Replace std::size with std::extent
@shalinijoshi19 shalinijoshi19 added the Area-Performance Tracking issues around perf/renderer latency etc label Jun 24, 2020
@shalinijoshi19
Copy link
Member

@paulcam206 does the release/1.2 branch actually need the UWP CI to be executed manually?

@chriche-ms chriche-ms self-assigned this Jun 26, 2020
@paulcam206
Copy link
Member

/azp run AdaptiveCards-.NET-PR [release 1.2]

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@paulcam206
Copy link
Member

/azp run AdaptiveCards-UWP-Daily-PRs [release 1.2]

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@paulcam206 paulcam206 merged commit a0cb0c8 into microsoft:release/1.2 Jun 29, 2020
@chriche-ms chriche-ms deleted the chriche/1.2/uwp_performance_base64_cherrypick branch June 30, 2020 09:42
@shalinijoshi19 shalinijoshi19 added this to the 20.06 milestone Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Performance Tracking issues around perf/renderer latency etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants