Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS][RichTextBlock Rendering] [Parity issue in RichTextBlock TextRun with action] #4531

Closed
adumrewal opened this issue Aug 4, 2020 · 7 comments · Fixed by #6180
Closed
Assignees
Labels
Area-Inconsistency Bugs around renderer inconsistencies across different platforms Bug Design Discussion - Needed Issue requires a design discussion before proceeding Partner-MsftTeams Issues related to AC integration with Microsoft Teams partner Partner-MsftTeamsMobile Bugs related specifically to Teams Mobile integration (iOS/Android) Platform-iOS

Comments

@adumrewal
Copy link

Platform

What platform is your issue or question related to? (Delete other platforms).

  • iOS

Author or host

Host - Teamspace iOS

Version of SDK

1.2.10

Details

TextRun in a RichTextBlock with selectAction renders differently across clients with difference in text color and underline style.
Desktop:
Screenshot 2020-08-04 at 4 55 09 PM
iOS:
Screenshot 2020-08-04 at 6 15 04 PM

cardJSON:

{
  "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
  "type": "AdaptiveCard",
  "version": "1.2",
  "body": [
    {
      "type": "RichTextBlock",
      "inlines": [
        {
          "type": "TextRun",
          "text": "This is the first inline.",
          "selectAction": {
            "type": "Action.OpenUrl",
            "title": "Action.OpenUrl",
            "url": "http://adaptivecards.io"
          }
        }
      ]
    }
  ]
}
@adumrewal adumrewal added the Bug label Aug 4, 2020
@ghost ghost added the Triage-Needed label Aug 4, 2020
@shalinijoshi19 shalinijoshi19 added Partner-MsftTeamsMobile Bugs related specifically to Teams Mobile integration (iOS/Android) Partner-MsftTeams Issues related to AC integration with Microsoft Teams partner Platform-iOS labels Aug 10, 2020
@shalinijoshi19
Copy link
Member

shalinijoshi19 commented Aug 10, 2020

@matthidinger / @dclaux / @RebeccaAnne is this supposed to be by design depending on how each platform renders hyperlinks for this specific case where the selectAction is of type "OpenUrl"? @almedina-ms assigning to you to take the investigation forward. Please update the bug with what you find.

@ghost ghost removed the Triage-Needed label Aug 10, 2020
@ghost
Copy link

ghost commented Aug 10, 2020

Hi @adumrewal. We have acknowledged this issue report. Please continue to follow this issue for updates/progress/questions.

@RebeccaAnne RebeccaAnne added the Area-Inconsistency Bugs around renderer inconsistencies across different platforms label Aug 10, 2020
@jwoo-msft jwoo-msft assigned jwoo-msft and unassigned almedina-ms Aug 26, 2020
@jwoo-msft jwoo-msft added this to the 20.09 milestone Aug 26, 2020
@jwoo-msft
Copy link
Member

jwoo-msft commented Aug 26, 2020

@jwoo-msft Check the default style of Android.
Android uses underline as well for the select action.

@jwoo-msft jwoo-msft added Design Discussion - Needed Issue requires a design discussion before proceeding and removed Design Discussion - Needed Issue requires a design discussion before proceeding labels Sep 9, 2020
@shalinijoshi19 shalinijoshi19 removed this from the 20.09 milestone Sep 21, 2020
@ghost ghost added the AdaptiveCards v20.09 label Sep 21, 2020
@shalinijoshi19 shalinijoshi19 added this to the 20.09 milestone Sep 21, 2020
@jwoo-msft jwoo-msft modified the milestones: 20.09, 20.10 Sep 25, 2020
@ghost ghost added the AdaptiveCards v20.11 label Nov 5, 2020
@jwoo-msft jwoo-msft modified the milestones: 20.11-12, Backlog Nov 25, 2020
@ghost ghost removed the AdaptiveCards v20.11 label Nov 25, 2020
@RebeccaAnne RebeccaAnne removed this from the Backlog milestone May 6, 2021
@anbah34
Copy link

anbah34 commented May 24, 2021

@jwoo-msft Can you please add this to the next SDK uptake?

@jwoo-msft jwoo-msft added the Design Discussion - Needed Issue requires a design discussion before proceeding label May 26, 2021
@jwoo-msft
Copy link
Member

@RebeccaAnne and @paulcam206
Should we discuss this in the design discussion meeting or can we just use the procedure we defined for handling missing and invalid values of required properties?

@anbah34
Copy link

anbah34 commented Jun 3, 2021

@jwoo-msft any updates on this?

@jwoo-msft
Copy link
Member

Gentle ping to @jonmill, @RebeccaAnne and @paulcam206

jwoo-msft added a commit that referenced this issue Aug 10, 2021
@jwoo-msft jwoo-msft added this to the 21.08 milestone Aug 11, 2021
jwoo-msft added a commit that referenced this issue Aug 17, 2021
@ghost ghost added Status-Fixed and removed Triage-Investigate labels Aug 17, 2021
michaelfarnsworth pushed a commit to michaelfarnsworth/AdaptiveCards that referenced this issue Nov 10, 2022
rankush pushed a commit to rankush/AdaptiveCards that referenced this issue May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Inconsistency Bugs around renderer inconsistencies across different platforms Bug Design Discussion - Needed Issue requires a design discussion before proceeding Partner-MsftTeams Issues related to AC integration with Microsoft Teams partner Partner-MsftTeamsMobile Bugs related specifically to Teams Mobile integration (iOS/Android) Platform-iOS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants