Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS][Image - repeatHorizontally] [Parity issue: iOS requires minimum height to render background image] #4832

Closed
adumrewal opened this issue Sep 28, 2020 · 5 comments · Fixed by #4918
Closed

[iOS][Image - repeatHorizontally] [Parity issue: iOS requires minimum height to render background image] #4832

adumrewal opened this issue Sep 28, 2020 · 5 comments · Fixed by #4918
Assignees
@jwoo-msft
Labels
Area-Inconsistency Bugs around renderer inconsistencies across different platforms Bug High Priority
Milestone
20.10

Comments

@adumrewal
Copy link

Platform

What platform is your issue or question related to? (Delete other platforms).

  • iOS

Author or host

Host - Teams iOS Client

Version of SDK

1.2.10

Details

On iOS if minHeight for Container is not defined, backgroundImage with fillMode "RepeatHorizontally" fails to render. However Android/Web render the card correctly.
PFA sample card json and screenshots:
iOS:
Screenshot 2020-09-28 at 2 00 41 PM
Desktop:
Screenshot 2020-09-28 at 2 01 32 PM

Card Json:
backgroundImage.txt
@adumrewal adumrewal added the Bug label Sep 28, 2020
@ghost ghost added this to the 20.10 milestone Sep 28, 2020
@ghost ghost added the Area-Inconsistency Bugs around renderer inconsistencies across different platforms label Sep 28, 2020
@ghost
Copy link

ghost commented Sep 28, 2020

please review this issue for target Milestone, Inconsistencies & Priority upon triage.

@ghost
Copy link

ghost commented Sep 28, 2020

Hi @adumrewal. We have acknowledged this issue report. Please continue to follow this issue for updates/progress/questions.

@jwoo-msft jwoo-msft self-assigned this Sep 29, 2020
@jwoo-msft
Copy link
Member

@adumrewal
image

Is your payload correct?
I tested it with main branch, and it doesn't look different.

Thanks

@jwoo-msft jwoo-msft mentioned this issue Oct 13, 2020
Merged
@ghost
Copy link

ghost commented Oct 31, 2020

🎉AdaptiveCards@2020.10 has been released which fixes this issue.:tada:

Handy links:

@ghost
Copy link

ghost commented Oct 31, 2020

🎉This issue is now fixed by #4918 and successfully released as part of our AdaptiveCards@2020.10 offering.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jwoo-msft jwoo-msft

Labels
Area-Inconsistency Bugs around renderer inconsistencies across different platforms Bug High Priority
Projects
None yet
Milestone
20.10
Development

Successfully merging a pull request may close this issue.

Jwoo/ios column microsoft/AdaptiveCards
2 participants
@jwoo-msft @adumrewal