Jwoo/ios column #4918
Merged
Jwoo/ios column #4918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jwoo-msft. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along. |
|
Hi @RebeccaAnne; Thanks for reviewing this previously stale pull request. Resetting staleness. @jwoo-msft FYI. |
|
🎉 Handy links: |
ghost
mentioned this pull request
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* updated image renderer * Final adjustment to vertical axis hugging priority
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
reference #4504
fixed #4832
Description
Updated Image to change its CRHP (compression resistance hugging priority) according to the column width value. For example, when the image has an explicitly pixel width and dimension, CRHP will be set to the maximum value. However, this behavior is not what we want when a column width value is set to
stretch. For more information oncolumnwidth, please check with Alberto's design discussion on 10/7. When acolumnisstretch, we wantimageto be stretchable and at the same time compressible. This change allows images to have less thanNSLayoutPrioirtyRequiredin such cases.How Verified
How you verified the fix, including one or all of the following:
Before [iOS-UWP][ColumnSet Parity Issue] [Parity issue between iOS and desktop for image width in columnSet] #4504
After
Fixed result for #4832
Microsoft Reviewers: Open in CodeFlow