Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS][Input validation] [Card UX issue : when error message is displayed on the card on button click] #4835

Closed
jyoti-ms opened this issue Sep 28, 2020 · 7 comments · Fixed by #4853
Assignees
Labels
Area-Inconsistency Bugs around renderer inconsistencies across different platforms Bug High Priority Partner-MsftTeams Issues related to AC integration with Microsoft Teams partner Partner-MsftTeamsMobile Bugs related specifically to Teams Mobile integration (iOS/Android)
Milestone

Comments

@jyoti-ms
Copy link

Platform

What platform is your issue or question related to?

  • iOS

Author or host

Host - Teams iOS Client

Version of SDK

SDK 2.1.0 (Adaptive card v1.3)

Details

An error message is shown on the card when input validation check is not passed on submit button click.

SDK send method is not triggering any onClick event to the client whenever input validation failed and error messages are shown directly.

In teams, we need to refresh the superview's layout (table view cell layout) that contains the adaptive card whenever error message is shown on the card as height of the adaptive card view has increased (changed by the SDK).

This is causing the UX to squeeze when user clicks on action.submit button. SDK is handling this right now and updating the layout for adaptive card only.

PFA screenshot:
image

@jyoti-ms jyoti-ms added the Bug label Sep 28, 2020
@ghost ghost added this to the 20.10 milestone Sep 28, 2020
@ghost ghost added the Area-Inconsistency Bugs around renderer inconsistencies across different platforms label Sep 28, 2020
@ghost
Copy link

ghost commented Sep 28, 2020

please review this issue for target Milestone, Inconsistencies & Priority upon triage.

@jyoti-ms jyoti-ms changed the title [iOS][Input validation][UX is squeezed when error message is displayed on the card on button click] [iOS][Input validation] [UX is squeezed when error message is displayed on the card on button click] Sep 28, 2020
@jyoti-ms jyoti-ms changed the title [iOS][Input validation] [UX is squeezed when error message is displayed on the card on button click] [iOS][Input validation] [Card UX issue : when error message is displayed on the card on button click] Sep 28, 2020
@ghost ghost removed the Triage-Needed label Sep 28, 2020
@ghost
Copy link

ghost commented Sep 28, 2020

Hi @jyoti-ms. We have acknowledged this issue report. Please continue to follow this issue for updates/progress/questions.

@ghost ghost added the Triage-Investigate label Sep 28, 2020
@jyoti-ms
Copy link
Author

@shalinijoshi19 @dclaux @jwoo-msft We are facing this issue as we are upgrading to the latest SDK in Teams. Can you please triage and let us know how we can work around this.
FYI: @sowrabh-msft @VikrantSingh01

@jwoo-msft
Copy link
Member

@jyoti-ms As we have discussed, SDK will send layout change notification.

@jyoti-ms
Copy link
Author

Thanks @jwoo-msft. yes, sending layout change notification on button click should work.

@shalinijoshi19 shalinijoshi19 added the Partner-MsftTeamsMobile Bugs related specifically to Teams Mobile integration (iOS/Android) label Oct 7, 2020
@shalinijoshi19 shalinijoshi19 added the Partner-MsftTeams Issues related to AC integration with Microsoft Teams partner label Oct 7, 2020
@shalinijoshi19
Copy link
Member

@sowrabh-msft FYI this issue has been addressed with our last patch. thanks

@jwoo-msft jwoo-msft self-assigned this Oct 15, 2020
@jwoo-msft jwoo-msft modified the milestones: 20.10, 20.09 Oct 15, 2020
@ghost ghost added the AdaptiveCards v20.09 label Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Inconsistency Bugs around renderer inconsistencies across different platforms Bug High Priority Partner-MsftTeams Issues related to AC integration with Microsoft Teams partner Partner-MsftTeamsMobile Bugs related specifically to Teams Mobile integration (iOS/Android)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants