Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Layout Change Notification #4853

Merged
merged 9 commits into from
Sep 30, 2020

Conversation

jwoo-msft
Copy link
Member

@jwoo-msft jwoo-msft commented Sep 30, 2020

Related Issue

Fixed #4835

Description

  • Added layout change notification such that if ACRView is used inside UITableView, the view would know that the row has changed.

How Verified

How you verified the fix, including one or all of the following:

  1. The notification already exists, so checked that notification are sent when there are layout changes with all existing Input cards.
  2. Run the existing relevant test cards.
Microsoft Reviewers: Open in CodeFlow

@jwoo-msft jwoo-msft changed the base branch from main to jwoo/input-error-ui-update September 30, 2020 01:39
@jwoo-msft
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@jwoo-msft jwoo-msft changed the base branch from jwoo/input-error-ui-update to main September 30, 2020 18:41
@jwoo-msft jwoo-msft merged commit a8c3afb into main Sep 30, 2020
@jwoo-msft jwoo-msft deleted the jwoo/input-layout-change-notification-update branch September 30, 2020 20:54
jwoo-msft added a commit that referenced this pull request Sep 30, 2020
* Added options to change styles for error cue for input

* removed erroneous check-in

* dev complete

* Added options to change styles for error cue for input

* removed erroneous check-in

* dev complete

* reverting changes unrelated to this PR
rankush pushed a commit to rankush/AdaptiveCards that referenced this pull request May 8, 2024
* Added options to change styles for error cue for input

* removed erroneous check-in

* dev complete

* Added options to change styles for error cue for input

* removed erroneous check-in

* dev complete

* reverting changes unrelated to this PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS][Input validation] [Card UX issue : when error message is displayed on the card on button click]
2 participants