Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility] Narrator is not reading the selection action title for the Rich Text Block #4856

Closed
3 tasks done
ridwived-microsoft opened this issue Sep 30, 2020 · 10 comments
Assignees
Labels
Area-Accessibility Bugs around feature accessibility Area-Inconsistency Bugs around renderer inconsistencies across different platforms Bug
Milestone

Comments

@ridwived-microsoft
Copy link

ridwived-microsoft commented Sep 30, 2020

Platforms

See also #5310(iOS) and #5311(Android)

Author or host

Host, D365, Customer Service Workspace app

Version of SDK

1.3

Repro

With the below RichTextBlock, Narrator should read "Click me" when the focus is on the RichTextBlock, but it reads "This is the text"

{
  "type": "AdaptiveCard",
  "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
  "version": "1.3",
  "body": [
    {
      "type": "RichTextBlock",
      "inlines": [
        {
          "type": "TextRun",
          "text": "This is the text",
          "selectAction": {
            "type": "Action.Submit",
            "title": "Click me"
          }
        }
      ]
    }
  ]
}
@ghost ghost added this to the 20.10 milestone Sep 30, 2020
@ghost ghost added the Area-Inconsistency Bugs around renderer inconsistencies across different platforms label Sep 30, 2020
@ghost
Copy link

ghost commented Sep 30, 2020

please review this issue for target Milestone, Inconsistencies & Priority upon triage.

@ridwived-microsoft
Copy link
Author

The narrator is expected to read the 'title' property on the selection action rather than the 'text' property of the text run in the rich text block

@dclaux dclaux changed the title [Azure Bot - Adaptive Card][Accessibility - Narrator is not reading the selection action title for the Rich Text Block [JS][Accessibility] Narrator is not reading the selection action title for the Rich Text Block Sep 30, 2020
@shalinijoshi19
Copy link
Member

shalinijoshi19 commented Oct 2, 2020

@dclaux can you add a quick summary here of the changes you are making as part of addressing this? Thanks. Feel free to unassign yourself once you've updated this bug with any specifics so the other platforms can follow suit! @paulcam206 FYI as a reminder to pick up/drive across teh rest of the platforms as Accessibility champion.

@ghost
Copy link

ghost commented Oct 2, 2020

Hi @ridwived-microsoft. We have acknowledged this issue report. Please continue to follow this issue for updates/progress/questions.

@dclaux
Copy link
Member

dclaux commented Oct 2, 2020

@shalinijoshi19 the change I am making is in the title of the PR: "Use TextRun.selectAction.title as aria-label"

@ghost ghost added the AdaptiveCards v20.10 label Oct 22, 2020
@shalinijoshi19 shalinijoshi19 modified the milestones: 20.10, 20.11 Oct 26, 2020
@shalinijoshi19
Copy link
Member

shalinijoshi19 commented Oct 26, 2020

@RebeccaAnne FYI -- can we look into this one to understand the behavior on the rest of the platforms for next sprint? I've moved it out.

@ghost ghost removed the AdaptiveCards v20.10 label Oct 26, 2020
@ghost ghost added the AdaptiveCards v20.11 label Nov 5, 2020
@RebeccaAnne RebeccaAnne added the Area-Accessibility Bugs around feature accessibility label Dec 2, 2020
@RebeccaAnne RebeccaAnne modified the milestones: 20.11-12, 21.01 Dec 2, 2020
@RebeccaAnne RebeccaAnne changed the title [JS][Accessibility] Narrator is not reading the selection action title for the Rich Text Block [Accessibility] Narrator is not reading the selection action title for the Rich Text Block Dec 2, 2020
@ghost ghost removed the AdaptiveCards v20.11 label Dec 3, 2020
@ghost ghost added the AdaptiveCards v21.01 label Dec 18, 2020
@RebeccaAnne
Copy link
Contributor

This behaves as expected in UWP

@RebeccaAnne
Copy link
Contributor

The bug repros on .NET WPF

@RebeccaAnne
Copy link
Contributor

@jwoo-msft @golddove Could you guys check if this works as expected on iOS/Android? Thanks!

@RebeccaAnne
Copy link
Contributor

Spun of iOS and Android to separate bugs to investigate and fix if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Accessibility Bugs around feature accessibility Area-Inconsistency Bugs around renderer inconsistencies across different platforms Bug
Projects
None yet
Development

No branches or pull requests

7 participants