Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JS][Renderer] Use TextRun.selectAction.title as aria-label #4857

Merged
merged 1 commit into from
Sep 30, 2020
Merged

[JS][Renderer] Use TextRun.selectAction.title as aria-label #4857

merged 1 commit into from
Sep 30, 2020

Conversation

dclaux
Copy link
Member

@dclaux dclaux commented Sep 30, 2020 •
edited
Loading

Related Issue

References #4856

Description

When a TextRun in a RichTextBlock has its selectAction set, the aria-label of the generated anchor DOM element is now set to the action's title property, if specified.

How Verified

Verified manually in adaptivecards-designer-app

Microsoft Reviewers: Open in CodeFlow

@ghost
Copy link

ghost commented Sep 30, 2020

Hi @dclaux. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

@dclaux dclaux merged commit 1c388e9 into main Sep 30, 2020
@dclaux dclaux deleted the ts/textrun-selectaction-accessibility branch September 30, 2020 17:26
@ghost ghost removed the AdaptiveCards v20.09 label Sep 30, 2020
@ghost
Copy link

ghost commented Oct 2, 2020

🎉AdaptiveCards@2020.09 has been released which fixes this issue.:tada:

Handy links:

@ghost
Copy link

ghost commented Oct 31, 2020

🎉AdaptiveCards@2020.10 has been released which fixes this issue.:tada:

Handy links:

@RebeccaAnne RebeccaAnne mentioned this pull request Jan 7, 2021
Closed
3 tasks
@MYBUSYBEEINC MYBUSYBEEINC mentioned this pull request Oct 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthidinger matthidinger matthidinger approved these changes

@paulcam206 paulcam206 paulcam206 approved these changes

@golddove golddove Awaiting requested review from golddove

@shalinijoshi19 shalinijoshi19 Awaiting requested review from shalinijoshi19

Assignees
No one assigned
Labels
Area-Accessibility Bugs around feature accessibility Area-Renderers Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dclaux @matthidinger @paulcam206