Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[All][Accessibility] Voice Over issue in Input Field Label #4898

Closed
2 tasks done
sowrabh-msft opened this issue Oct 9, 2020 · 12 comments
Closed
2 tasks done

[All][Accessibility] Voice Over issue in Input Field Label #4898

sowrabh-msft opened this issue Oct 9, 2020 · 12 comments
Assignees
Labels
Area-Accessibility Bugs around feature accessibility Area-Inconsistency Bugs around renderer inconsistencies across different platforms Bug High Priority Partner-MsftTeams Issues related to AC integration with Microsoft Teams partner Partner-MsftTeamsMobile Bugs related specifically to Teams Mobile integration (iOS/Android) Platform-Android Platform-iOS
Milestone

Comments

@sowrabh-msft
Copy link
Contributor

sowrabh-msft commented Oct 9, 2020

All platforms

Host

Microsoft Teams

Version of SDK

SDK version 2.1.0 (ACv1.3)

Details

When the user goes into the card and selects/shifts focus to an input field, the field label is not called out which results in users being unable to identify what they are supposed to fill in the particular field. Only an issue on the mobile platforms.

Fix: Call out input label as well while emphasis is on field.
Link to video

@ghost ghost added this to the 20.10 milestone Oct 9, 2020
@ghost ghost added the Area-Inconsistency Bugs around renderer inconsistencies across different platforms label Oct 9, 2020
@ghost
Copy link

ghost commented Oct 9, 2020

please review this issue for target Milestone, Inconsistencies & Priority upon triage.

@shalinijoshi19 shalinijoshi19 added Area-Accessibility Bugs around feature accessibility Partner-MsftTeamsMobile Bugs related specifically to Teams Mobile integration (iOS/Android) Partner-MsftTeams Issues related to AC integration with Microsoft Teams partner labels Oct 9, 2020
@shalinijoshi19
Copy link
Member

@sowrabh-msft is there guidance around localizing the voice over text here at all to reconcile with the user locale settings?
@paulcam206 / @almedina-ms is this something that we are aware of with voiceover/narrator?

@ghost
Copy link

ghost commented Oct 9, 2020

Hi @sowrabh-msft. We have acknowledged this issue report. Please continue to follow this issue for updates/progress/questions.

@ghost ghost added the Triage-Investigate label Oct 9, 2020
@shiladityasaha
Copy link

Adding video links for easy access:
Item #1: Video
Item #2: Video

@jwoo-msft jwoo-msft added Platform-Android Platform-iOS and removed Partner-MsftTeamsMobile Bugs related specifically to Teams Mobile integration (iOS/Android) labels Oct 10, 2020
@jwoo-msft jwoo-msft changed the title [Android|iOS][Accessibility] Input Validation Accessibility issues in Voice Over [Android|iOS][Accessibility] Voice Over in Input Field Label Oct 12, 2020
@jwoo-msft jwoo-msft changed the title [Android|iOS][Accessibility] Voice Over in Input Field Label [All][Accessibility] Voice Over issue in Input Field Label Oct 12, 2020
@jwoo-msft jwoo-msft assigned golddove and jwoo-msft and unassigned almedina-ms Oct 12, 2020
@jwoo-msft
Copy link
Member

jwoo-msft commented Oct 12, 2020

possible 20.10 if it's P0
iOS @jwoo-msft
Android @golddove

@shiladityasaha
Copy link

@shalinijoshi19 this is a ring blocker on all platforms for us. Hopefully this can be picked up for desktop too?

@jwoo-msft jwoo-msft added the Partner-MsftTeamsMobile Bugs related specifically to Teams Mobile integration (iOS/Android) label Oct 15, 2020
@dclaux
Copy link
Member

dclaux commented Oct 15, 2020

I am not able to repro this in Edge or Chrome on Windows with Narrator. All the appropriate From the first video (I don't have access to the other two) it looks like the problem happens in WebChat on iOS, is that correct?

I am not able to repro this in Edge or Chrome on Windows with Narrator. All the appropriate aria properties are set, and narration is as expected.

I suspect this is a case of WebChat not being updated to use the latest AC SDK in which a number of accessibility bugs were fixed.

@golddove
Copy link
Member

golddove commented Oct 15, 2020

@shiladityasaha we have split the bug you've filed, as it had two separate issues. The second part has been moved to #4912. So, I think you are referring to that for desktop?

This issue has been edited to only track the first part, which should only be on mobile. Please confirm if that's correct.

@golddove
Copy link
Member

For Android, likely fixed by #4930. Need to test.

@shalinijoshi19
Copy link
Member

@jwoo-msft
Copy link
Member

@shalinijoshi19 This issue will be taken together with #4912

@golddove
Copy link
Member

Validated on Android. Works on v1.3/Tests/InputValidationTestCard.json as expected (reads the associated label for each EditText).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Accessibility Bugs around feature accessibility Area-Inconsistency Bugs around renderer inconsistencies across different platforms Bug High Priority Partner-MsftTeams Issues related to AC integration with Microsoft Teams partner Partner-MsftTeamsMobile Bugs related specifically to Teams Mobile integration (iOS/Android) Platform-Android Platform-iOS
Projects
None yet
Development

No branches or pull requests

8 participants